From 8d7179078136e2385cdcb3047789f96c47423932 Mon Sep 17 00:00:00 2001 From: Code-Review-Bot-Commits Date: Tue, 5 Nov 2024 23:14:00 +0530 Subject: [PATCH] Update sal_json.py --- sal_json.py | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/sal_json.py b/sal_json.py index 382bd7f..03464bc 100644 --- a/sal_json.py +++ b/sal_json.py @@ -2,9 +2,9 @@ import json import csv -class Employee: - def __init__(self, employee_id, name, position, salary): - self.employee_id = employee_id +class Emplyee: # Error: Typo in class name + def __init__(self, emp_id, name, position, salary): # Error: Wrong parameter name (emp_id should be employee_id) + self.emp_id = emp_id # Error: Wrong attribute name (self.emp_id should be self.employee_id) self.name = name self.position = position self.salary = salary @@ -14,7 +14,7 @@ def give_raise(self, amount): def to_dict(self): return { - 'employee_id': self.employee_id, + 'employee_id': self.emp_id, # Error: Wrong attribute name (self.emp_id should be self.employee_id) 'name': self.name, 'position': self.position, 'salary': self.salary @@ -29,8 +29,8 @@ def read_employees_from_csv(file_path): reader = csv.DictReader(file) for row in reader: try: - employee = Employee( - employee_id=row['employee_id'], + employee = Emplyee( # Error: Typo in class name + emp_id=row['employee_id'], # Error: Wrong parameter name (emp_id should be employee_id) name=row['name'], position=row['position'], salary=float(row['salary']) @@ -44,18 +44,19 @@ def save_employees_to_json(employees, output_file): with open(output_file, 'w') as file: json.dump([employee.to_dict() for employee in employees], file, indent=4) -def main(): - input_file = 'employees.csv' - output_file = 'employees.json' +def main(): # Error: Missing indentation for this function +input_file = 'employees.csv' # Error: Incorrect indentation +output_file = 'employees.json' # Error: Incorrect indentation try: - employees = read_employees_from_csv(input_file) + employees = read_employees_from_csv(input_file) # Error: Incorrect indentation for employee in employees: - employee.give_raise(5000) # Give each employee a raise - save_employees_to_json(employees, output_file) - print(f"Employee data has been saved to {output_file}") + employee.give_raise(5000) # Error: Incorrect indentation + save_employees_to_json(employees, output_file) # Error: Incorrect indentation + print(f"Employee data has been saved to {output_file}") # Error: Incorrect indentation except Exception as e: - print(f"An error occurred: {e}") + print(f"An error occurred: {e}") # Error: Incorrect indentation if __name__ == "__main__": main() +