Is this a critical security issue?
Describe the Bug
The virtual fact on Windows works by checking the model/manufacturer against a regex.
https://github.com/OpenVoxProject/openfact/blob/main/lib/facter/resolvers/windows/virtualization.rb#L52
This results in the fact returning physical.
Example for the manufacture under proxmoxr: QEMU
Pull requests incoming soon tm. :)
Expected Behavior
Windows on Proxmox should return virtual = kvm
like it does on Linux hosts.
Steps to Reproduce
- Use proxmox / kvm as a hypervisor
- use windows as your guest OS
- fact returns physical
Environment
Version OpenVox 8.28.0
Platform Windows Server 2019 / Proxmox Virtual Environment 2019
Additional Context
No response
Relevant log output
Is this a critical security issue?
Describe the Bug
The virtual fact on Windows works by checking the model/manufacturer against a regex.
https://github.com/OpenVoxProject/openfact/blob/main/lib/facter/resolvers/windows/virtualization.rb#L52
This results in the fact returning physical.
Example for the manufacture under proxmoxr:
QEMUPull requests incoming soon tm. :)
Expected Behavior
Windows on Proxmox should return virtual = kvm
like it does on Linux hosts.
Steps to Reproduce
Environment
Version OpenVox 8.28.0
Platform Windows Server 2019 / Proxmox Virtual Environment 2019
Additional Context
No response
Relevant log output