Build failure

[SolitudeSF]

sgdboop.c:1280:60: error: too many arguments to function ‘getMods’; expected 0, have 1
 1280 |                                                 appsMods = getMods(includeMods);
      |                                                            ^~~~~~~ ~~~~~~~~~~~

gcc 15

[muznyo]

same issue

[raku-cat]

This is due to the gcc15 update, if you run the build with CC=gcc-14 set it will build with gcc14 and the build succeeds.

[Djihads80]

thank you, seems to have fixed the problem

for anyone who's installing this from a package manager on arch linux, use yay and run these commands
(process should be similar on other distros)

Install gcc 14 (if not already installed):

sudo pacman -S gcc14

Run:

yay -G sgdboop cd sgdboop

Edit the PKGBUILD:

nano PKGBUILD

Add this line before the make or build() function:

export CC=gcc-14 export CXX=g++-14

then build

makepkg -si

[papaj-na-wrotkach]

You can also just specify the environment variables before using your pacman wrapper.

CC=gcc-14 CXX=g++-14 paru -S sgdboop

I am curious, what changed in gcc15 that it can't compile SGDBoop?

[raku-cat]

You can also just specify the environment variables before using your pacman wrapper.

CC=gcc-14 CXX=g++-14 paru -S sgdboop
I am curious, what changed in gcc15 that it can't compile SGDBoop?

Broke builds for a lot of projects, I believe it was the change to C23, but 15 was a big bump, could've been any number of other changes.

[papaj-na-wrotkach]

You can also just specify the environment variables before using your pacman wrapper.
CC=gcc-14 CXX=g++-14 paru -S sgdboop
I am curious, what changed in gcc15 that it can't compile SGDBoop?

Broke builds for a lot of projects, I believe it was the change to C23, but 15 was a big bump, could've been any number of other changes.

Alright, thanks. I am just trying to analyze how this C code works because I never really used C (only very basic C++).

getMods is defined like this:

SGDBoop/sgdboop.c

Lines 933 to 959 in 9be5d26

	struct nonSteamApp* getMods() {
	struct nonSteamApp* apps = malloc(sizeof(nonSteamApp) * 1500000);
	struct nonSteamApp* sourceMods = getSourceMods("source");
	struct nonSteamApp* goldSourceMods = getSourceMods("goldsource");
	for (int i = 0; i < _sourceModsCount; i++) {
	apps[_modsCount].index = _modsCount;
	strcpy(apps[_modsCount].name, sourceMods[i].name);
	strcpy(apps[_modsCount].appid_old, sourceMods[i].appid_old);
	strcpy(apps[_modsCount].appid, sourceMods[i].appid);
	strcpy(apps[_modsCount].type, "source-mod");
	_modsCount++;
	}
	for (int i = 0; i < _goldSourceModsCount; i++) {
	apps[_modsCount].index = _modsCount;
	strcpy(apps[_modsCount].name, goldSourceMods[i].name);
	strcpy(apps[_modsCount].appid_old, goldSourceMods[i].appid_old);
	strcpy(apps[_modsCount].appid, goldSourceMods[i].appid);
	strcpy(apps[_modsCount].type, "goldsource-mod");
	_modsCount++;
	}
	free(sourceMods);
	free(goldSourceMods);
	return apps;
	}

It is used here:

SGDBoop/sgdboop.c

Lines 1279 to 1281 in 9be5d26

	if (includeMods) {
	appsMods = getMods(includeMods);
	}

Why is includeMods passed to getMods? I don't see how it is used there. Shouldn't getMods be defined like this and used without any arguments?

struct nonSteamApp* getMods(void)

I think you are right about the change to C23. C always treated empty parentheses as unknown number of unknown arguments, right? It might be that for C23 getMods() is now the same as getMods(void), just like in C++.

I might be wrong though - as I said I have no experience with C 😅

[claymorwan]

thank you, seems to have fixed the problem

for anyone who's installing this from a package manager on arch linux, use yay and run these commands (process should be similar on other distros)

Install gcc 14 (if not already installed):

sudo pacman -S gcc14

Run:

yay -G sgdboop cd sgdboop

Edit the PKGBUILD:

nano PKGBUILD

Add this line before the make or build() function:

export CC=gcc-14 export CXX=g++-14

then build

makepkg -si

just tried to add this to the PKGBUILD but it's literally not doing anything, just exits with no error or output

[papaj-na-wrotkach]

If you want to edit the PKGBUILD, just change gcc to gcc-14 in makedepends and in build function change make to CC=gcc-14 CXX=g++-14 make.

It is easier to use env vars with an AUR helper (or makepkg) as I suggested here. You can also export the env vars before running the commands as usual.

I think your problem was putting two export statements in one line. It should be either

export CC=gcc-14 CXX=g++-14

or

export CC=gcc-14
export CXX=g++-14

[claymorwan]

It is easier to use env vars with an AUR helper (or makepkg) as I suggested here. You can also export the env vars before running the commands as usual.

ye i could, the thing is i wanna actually do it in the PKGBUILD script cuz im the maintainer of the aur pkg and i want it to work directly with it

i exported the env variables line by line like u said and it worked now thanks, im gonna push it to the aur so it should work just fine now

[Djihads80]

thank you for maintaining SGDBoop for the aur twin ❤️

[claymorwan]

thank you for maintaining SGDBoop for the aur twin ❤️

yw twin, glad to help