[v5.4.2+fabric-26.2] "Home" tab's "Featured statistics" causes lag spike for players with large statistics

[Nakik]

2. What happened & steps to reproduce

opening Statics and clicking on Home freeze the game for few seconds than go back to working.
it can cause a black screen for 10seconds but continue to works normal. weird bug?

3. Debug logs / Crash report

4. Installed mods / Mod-pack

mod menu, fabric api

5. Code of Conduct

• I titled this issue properly
• This issue is related to the latest version of this mod
• If this issue is related to a crash, I provided a crash report
• I will answer any follow-up questions to help diagnose and resolve this issue

[TheCSDev]

Hello,
Thank you for reaching out to report an issue.

Because this does not appear to be a common issue that is easily reproduced (else there would be many people experiencing it), we will need to gather more information on it so I can try and diagnose it for you.
You mentioned handing only 2 other mods installed; 'Fabric API' and 'Mod Menu'. If it is true that you only have those mods present alongside this mod, then that rules out issues caused by other mods (stuff like mod conflicts), which makes diagnosis more difficult.

In any case, the additional information I will need is:

• latest.log file for the session where the issue occured
• Spark profiler output

Given the nature of the issue, it is not guaranteed that those two will help, but it is worth trying at the very least.

Obtaining latest.log

Open a new instance of Minecraft and reproduce the issue. Once reproduced, close the game and obtain the the latest.log file for that session.
You may upload the log file here, or alternatively use a log sharing service like https://mclo.gs/

Obtaining Sark profiler output

Spark is a profiler for Minecraft in form of a mod. It generates detailed reports on the performance of the game, down to how performant each line of the game's code is. Please use the link to download and install that mod, then read instructions below on how to generate a report.

The steps are simple;

1. Install that mod and then open the game
2. In game settings, reduce your render distance and simulation distance to minimum (to filter out stuff happening in the world from the profiler output)
3. Create a new superflat world with peaceful difficulty (to filter out terrain and mobs from the profiler output), then open the world
4. Execute the following command; /sparkclient profiler start
5. Immediately after, open the 'Statistics' screen and reproduce the issue
6. Immediately after, close the 'Statistics' screen and execute the following command; /sparkclient profiler stop
7. Spark will then upload the profiler result and generate a new URL that will then appear in chat. Share that URL here, and I will take a look.

I have also uploaded a short instructional video, just in case it helps;
https://github.com/user-attachments/assets/fadd0881-83e8-44aa-b3a7-42660018c4b6

[Nakik]

Hey, I checked little bit more and I pretty sure its about the specific world im playing.
its a survival world from 1.21 and updating for the last 2 years.
I think that the problem is the playerData(data folder) because of this video:
https://limewire.com/d/HT4hy#WZSqFGdrTU
Also the logs:
https://pastee.dev/p/TbdHpsAJ

[Nakik]

also the actual player data info:
stats.json:
63806b13-0b0c-4f74-bbc5-1249abedb60c.json

advancements:
63806b13-0b0c-4f74-bbc5-1249abedb60c.json
I can also upload player.dat if needed

[TheCSDev]

Oh wow, that is a good catch! Thank you!
It appears you are correct, as I was able to reproduce the issue on my end using your statistics file. I will now investigate and hopefully resolve the issue.

[Nakik]

Happy to help, if you need from me anything else I would love to help.

[TheCSDev]

Resolved; Publishing an update today.

Keep in mind that this might still happen on very large modpacks with tens of thousands of items and blocks. More registered entries means more work for the mod when it loads the stats. I may plan on optimizing the code further in the future, but mathematically speaking, there's no way around the fact that we have to loop through and check every single item.