From c0bfeb9961c6c54cf128539256537549c1d8d6ea Mon Sep 17 00:00:00 2001 From: Micrograx Date: Wed, 29 Apr 2026 15:52:01 -0300 Subject: [PATCH 1/2] Use builtin.null_list in both list and dict is_empty --- lib/aiken/collection/dict.ak | 5 +---- lib/aiken/collection/list.ak | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/lib/aiken/collection/dict.ak b/lib/aiken/collection/dict.ak index a984e0b..835ce30 100644 --- a/lib/aiken/collection/dict.ak +++ b/lib/aiken/collection/dict.ak @@ -379,10 +379,7 @@ fn do_has_key(self: Pairs, key k: ByteArray) -> Bool { /// dict.is_empty(dict.empty) == True /// ``` pub fn is_empty(self: Dict) -> Bool { - when self.inner is { - [] -> True - _ -> False - } + builtin.null_list(self.inner) } /// Extract all the keys present in a given `Dict`. diff --git a/lib/aiken/collection/list.ak b/lib/aiken/collection/list.ak index ef6a93d..ab0f461 100644 --- a/lib/aiken/collection/list.ak +++ b/lib/aiken/collection/list.ak @@ -205,10 +205,7 @@ pub fn head(self: List) -> Option { /// list.is_empty([1, 2, 3]) == False /// ``` pub fn is_empty(self: List) -> Bool { - when self is { - [] -> True - _ -> False - } + builtin.null_list(self) } /// Gets the index of an element of a list, if any. Otherwise, returns None. From e2f4743fd7b05507d49be163ada911fc4c1853c8 Mon Sep 17 00:00:00 2001 From: Valentino Cerutti Date: Fri, 8 May 2026 13:30:51 -0300 Subject: [PATCH 2/2] Use == [] in both list and dict is_empty --- lib/aiken/collection/dict.ak | 2 +- lib/aiken/collection/list.ak | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/aiken/collection/dict.ak b/lib/aiken/collection/dict.ak index 835ce30..32cf8af 100644 --- a/lib/aiken/collection/dict.ak +++ b/lib/aiken/collection/dict.ak @@ -379,7 +379,7 @@ fn do_has_key(self: Pairs, key k: ByteArray) -> Bool { /// dict.is_empty(dict.empty) == True /// ``` pub fn is_empty(self: Dict) -> Bool { - builtin.null_list(self.inner) + self.inner == [] } /// Extract all the keys present in a given `Dict`. diff --git a/lib/aiken/collection/list.ak b/lib/aiken/collection/list.ak index ab0f461..cda4059 100644 --- a/lib/aiken/collection/list.ak +++ b/lib/aiken/collection/list.ak @@ -205,7 +205,7 @@ pub fn head(self: List) -> Option { /// list.is_empty([1, 2, 3]) == False /// ``` pub fn is_empty(self: List) -> Bool { - builtin.null_list(self) + self == [] } /// Gets the index of an element of a list, if any. Otherwise, returns None.