Conversation
Make the asta plugins installable through npx plugins add into any agent the CLI supports. Make plugins/asta-preview the canonical source (all skills + hooks) and generate only the core plugins/asta subset from it, so the shared skills are no longer duplicated across both plugins. Add a CI job + verify script that check installation (skills + hooks) into Claude Code and Codex with no auth.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Distribute asta plugins via
npx plugins addEnables two things:
(skills + hooks) via the agent's native plugin system, not just loose skill
files (
npx skills add) or Claude Code's own marketplace.plugins/asta-preview/nowholds the skills (edit here);
plugins/astais generated as the core subset.Only those 5 core skills are still duplicated, down from the old layout where
a top-level
skills/was copied into both plugin dirs.No skill/hook content changes. The shipped plugin trees are byte-identical
to
main— SKILL.md, assets, scripts, workflows, and hooks. The PR deletes thenow-redundant top-level
skills/+hooks/(duplicates of the plugin copies — sothe diff shows deletions, not renames) and makes
plugins/asta-previewthecanonical source. Verify (empty diff = identical):
Layout, rationale, and the distribution matrix are in the
DEVELOPER.mddiff.Install is verified in CI with no auth (
plugin-installjob). The verifier runsunder a throwaway
HOME, sobash scripts/verify-plugin-install.sh <agent>issafe to run locally too (needs
claude/codexon PATH).Tests. The split is asserted from the filesystem (
TestPluginLayout);CLI-based tests are thin smokes that our repo is consumable by the real
installers. Removed the
npx skills --listdiscovery test — it re-checked theCLI's own discovery and coupled to its output wording (vercel's to test, not
ours), and the install smoke now asserts the same exact set via real install.
CLI smokes run against
@latest— whatnpx plugins add/npx skills addactually give users — so green means users can install, and an upstream break
reds CI immediately (the
SKILLS_CLI/PLUGINS_CLIenv vars pin as an emergencylever). New guards (in the diff) cover our own contract — marketplace sources
resolve, no committed per-plugin manifest,
metadata.internalis boolean.Not derivable from the diff: inspect-swe is unaffected —
-S skills=resolves
plugins/asta-preview/skills(kept), now guarded by the docker smoketest. Companion agent-baselines PR (allenai/agent-baselines#28):
points the inspect-swe swap-in-local-skills recipe at the now-canonical
plugins/asta-preview/skills(edit it directly). Land alongside this PR.