chore: Increase start_timeout and link it to Fluent's Idle timeout#5147
Draft
prmukherj wants to merge 10 commits into
Draft
chore: Increase start_timeout and link it to Fluent's Idle timeout#5147prmukherj wants to merge 10 commits into
prmukherj wants to merge 10 commits into
Conversation
Up to standards ✅🟢 Issues
|
prmukherj
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the default timeouts used when launching/connecting to Fluent and adds a launch-time “idle timeout” guard intended to auto-terminate Fluent if PyFluent never successfully connects (helping avoid stale Fluent processes after failed connections).
Changes:
- Increase the default Fluent launch/connect timeout from 60s to 180s (config + docs + standalone launcher default).
- In the standalone launcher, inject
-setenv=FLUENT_MAX_IDLE_TIMEOUT=<minutes>based onstart_timeoutto guard against stale processes on failed connection. - After a successful connection, attempt to reset the Fluent
Preferences -> General -> IdleTimeoutto0.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
src/ansys/fluent/core/module_config.py |
Updates the default launch_fluent_timeout from 60s to 180s. |
src/ansys/fluent/core/launcher/standalone_launcher.py |
Raises start_timeout default to 180s; injects an idle-timeout guard; resets IdleTimeout after connection. |
src/ansys/fluent/core/launcher/launcher.py |
Updates launch_fluent() docstring to reflect the new 180s default outside Slurm. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…s/pyfluent into maint/increase_idle_timeout
3 tasks
github-actions
Bot
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ut for Fluent.
Context
What was the situation or problem before this change?
Change Summary
What changes were made?
Rationale
Why was this approach taken?
Impact
What parts of the system or workflows are affected?