Fix failing tests

winterhazel · winterhazel · commit c839d86f1bf3 · 2026-06-19T10:49:58.000-03:00
diff --git a/plugins/hypervisors/vmware/src/test/java/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java b/plugins/hypervisors/vmware/src/test/java/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
@@ -904,7 +904,7 @@ private void configureSupportedDiskControllersForTests() {
         nvmeMapping.setMaxControllerCount(4);
         nvmeMapping.setMinHardwareVersion("13");
 
-        VmwareHelper.setSupportedDiskControllers(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping));
+        VmwareHelper.setSupportedDiskControllers(new ArrayList<>(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping)));
     }
 
     private Set<DiskControllerMappingVO> getRequiredDiskControllersForValidateRequiredVirtualHardwareVersionForNewDiskControllersTests() {
diff --git a/vmware-base/src/test/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMOTest.java b/vmware-base/src/test/java/com/cloud/hypervisor/vmware/mo/VirtualMachineMOTest.java
@@ -130,7 +130,7 @@ private void configureSupportedDiskControllersForTests() {
         nvmeMapping.setMaxControllerCount(4);
         nvmeMapping.setMinHardwareVersion("13");
 
-        VmwareHelper.setSupportedDiskControllers(List.of(osdefaultMapping, ideMapping, lsilogicMapping, nvmeMapping));
+        VmwareHelper.setSupportedDiskControllers(new ArrayList<>(List.of(osdefaultMapping, ideMapping, lsilogicMapping, nvmeMapping)));
     }
 
     @BeforeClass
diff --git a/vmware-base/src/test/java/com/cloud/hypervisor/vmware/util/VmwareHelperTest.java b/vmware-base/src/test/java/com/cloud/hypervisor/vmware/util/VmwareHelperTest.java
@@ -135,7 +135,7 @@ public void setUp() throws Exception {
         nvmeMapping.setBusName("nvme");
         nvmeMapping.setMaxDeviceCount(15);
         nvmeMapping.setMaxControllerCount(4);
-        VmwareHelper.setSupportedDiskControllers(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping));
+        VmwareHelper.setSupportedDiskControllers(new ArrayList<>(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping)));
 
         Mockito.when(virtualMachineConfigSpecMock.getDeviceChange()).thenReturn(new ArrayList<>());
     }

Original file line number	Diff line number	Diff line change
`@@ -904,7 +904,7 @@ private void configureSupportedDiskControllersForTests() {`
`904`	`904`	`nvmeMapping.setMaxControllerCount(4);`
`905`	`905`	`nvmeMapping.setMinHardwareVersion("13");`
`906`	`906`
`907`		`- VmwareHelper.setSupportedDiskControllers(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping));`
	`907`	`+ VmwareHelper.setSupportedDiskControllers(new ArrayList<>(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping)));`
`908`	`908`	`}`
`909`	`909`
`910`	`910`	`private Set<DiskControllerMappingVO> getRequiredDiskControllersForValidateRequiredVirtualHardwareVersionForNewDiskControllersTests() {`
Original file line number	Diff line number	Diff line change
`@@ -130,7 +130,7 @@ private void configureSupportedDiskControllersForTests() {`
`130`	`130`	`nvmeMapping.setMaxControllerCount(4);`
`131`	`131`	`nvmeMapping.setMinHardwareVersion("13");`
`132`	`132`
`133`		`- VmwareHelper.setSupportedDiskControllers(List.of(osdefaultMapping, ideMapping, lsilogicMapping, nvmeMapping));`
	`133`	`+ VmwareHelper.setSupportedDiskControllers(new ArrayList<>(List.of(osdefaultMapping, ideMapping, lsilogicMapping, nvmeMapping)));`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`@BeforeClass`
Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public void setUp() throws Exception {`
`135`	`135`	`nvmeMapping.setBusName("nvme");`
`136`	`136`	`nvmeMapping.setMaxDeviceCount(15);`
`137`	`137`	`nvmeMapping.setMaxControllerCount(4);`
`138`		`- VmwareHelper.setSupportedDiskControllers(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping));`
	`138`	`+ VmwareHelper.setSupportedDiskControllers(new ArrayList<>(List.of(osdefaultMapping, ideMapping, lsilogicMapping, pvscsiMapping, sataMapping, nvmeMapping)));`
`139`	`139`
`140`	`140`	`Mockito.when(virtualMachineConfigSpecMock.getDeviceChange()).thenReturn(new ArrayList<>());`
`141`	`141`	`}`