Bulk Operations (Actions) don't seem to be working.

[jenlampton]

I have a list of comments that are flagged. I have added the Flag (or unflag) comment action to my comment listing. When select this action and click "Execute" My comment does not get flagged (or unflagged) and instead I see the PHP warning:

Notice: Undefined index: flag in flag_comment_action() (line 134 of backdrop/modules/contrib/flag/includes/flag.actions.inc). 

The notice is correct, as there is no $context['flag_action']. There is however, $context['action_info'] but it does not seem to contain the values we need here.

---

PR: #22

[jenlampton]

From looking at hook_actions_info(), it appears as though Flag used configurable actions, which have been removed from core. The current recommended solutions for this are:

• use rules instead of actions
• Create a contrib module to extend actions to be configurable
• Restore configurable actions to core

I think I might work on the 3rd one.

I'm attaching a PR for Flag that will check the specified entity, and if there is only one flag for the entity type, will use that flag to flag or unflag the entity. If there is more than one, it will throw a warning.

[herbdool]

Thanks for taking a crack at this @jenlampton. I've got a variation of your PR #67. In my PR I've created a separate flag action for each flag and each entity type and also separate ones for flagging and unflagging. There are a few advantages to this:

• No need to restrict a View to just one flag.
• Handles any entity type to which a flag can be attached.
• Clearer action label.
• Can select a bunch of items and ensure they will all get flagged or unflagged, and not a mix of both.