Skip to content

Adjustments to hero component controls panel options #596

@natalia-fitzgerald

Description

@natalia-fitzgerald

Description

In the Storybook controls panel within the Hero Story there are options available that should not be modifiable. The purpose of this issue is to highlight the options that should be changed.

Controls that should be changed

  • Text color should not be a selection. isKnockout will change the text to white and is intended for instances where there is a dark background. For lighter backgrounds black is the default. No colors other than black or white should be used.
Image Image
  • The heading for the heroes supported in the DSR are always H1 at desktop and drop a level to match the H2 styling at mobile (standard responsive behavior for an H1).
Image
  • The subheading for the heroes always uses the hero_subhead style which includes responsive behavior. The text size of the subheading should not be customizable.
Image

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions