Skip to content

🐛 action trigger on manuel release on GitHub UI #50

Open
enryH wants to merge 1 commit into
daneah:mainfrom
enryH:trigger_release
Open

🐛 action trigger on manuel release on GitHub UI #50
enryH wants to merge 1 commit into
daneah:mainfrom
enryH:trigger_release

Conversation

@enryH

@enryH enryH commented Sep 6, 2023

Copy link
Copy Markdown
  • workflow was not triggered if the instruction on p. 124f were followed

Description of issue

Following the instructions in the book,
the GitHub actions were not triggered.

Description of solution

Add release triggers as described here:
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release

- workflow was not triggered if the instruction on p. 124f were followed
@enryH

enryH commented Sep 7, 2023

Copy link
Copy Markdown
Author

So this alone did not do the trick. I think the event ref just does not exist anymore, so the conditional startsWith needs to be changed additionally

@daneah

daneah commented Sep 8, 2023

Copy link
Copy Markdown
Owner

@enryH thank you for reporting this! Unfortunately this repository needs to remain static to align with the content in the book; I have suggested that I might create a living version that changes with the times (and only has one package, rather than several chapters' iterations on a package). That would be the place to fix this, to be sure. I'll leave this open and get back to you when that happens?

@enryH

enryH commented Sep 13, 2023

Copy link
Copy Markdown
Author

Hey! A live version of the repository would be great. Maybe you could test the pip package upload once a month using calendar versioning?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants