fix(python-sdk): preserve connect stream events#1396
Draft
cyq1017 wants to merge 1 commit into
Draft
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @cyq1017 on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1352
Problem
commands.connect(pid)can receive stream output before thestartevent. The Python SDK consumed those non-start events while waiting forstart, so early stdout/stderr frames were dropped from the returned command handle.Changes
startevent in sync and async PythonCommands.connect.startis established.Verification
uvx poetry run pytest tests/async/sandbox_async/commands/test_cmd_connect_stream.py tests/sync/sandbox_sync/commands/test_cmd_connect_stream.py -quvx poetry run ruff check e2b/sandbox_async/commands/command.py e2b/sandbox_sync/commands/command.py tests/async/sandbox_async/commands/test_cmd_connect_stream.py tests/sync/sandbox_sync/commands/test_cmd_connect_stream.pyuvx poetry run ruff format --check e2b/sandbox_async/commands/command.py e2b/sandbox_sync/commands/command.py tests/async/sandbox_async/commands/test_cmd_connect_stream.py tests/sync/sandbox_sync/commands/test_cmd_connect_stream.pygit diff HEAD^..HEAD --checkNote: scoped to Python SDK connect-stream replay; no hosted E2B sandbox was used.