Skip to content

Protect link new device#6992

Draft
bmarty wants to merge 5 commits into
developfrom
feature/bma/protectLinkNewDevice
Draft

Protect link new device#6992
bmarty wants to merge 5 commits into
developfrom
feature/bma/protectLinkNewDevice

Conversation

@bmarty

@bmarty bmarty commented Jun 8, 2026

Copy link
Copy Markdown
Member

Content

Protect access to link a new device by asking user to enter the in-app PIN code (using biometric if configured), or using the device protection, if set up.

Draft because waiting for product feedback.

Motivation and context

Ensure the user is the owner before allowing to link a new device

Screenshots / GIFs

Tests

  • Enable "Link new device" feature flag
  • Ensure the device access is protected, and EXA does not have any PIN code set up
  • Login to an account where link new device is supported (ex: account on element.io)
  • In the settings, select "Link new device"
  • Select "Desktop", and observe that the device biometric / shema / PIN code screen is presented. It can be canceled.
    • Do all the possible test: cancel, enter wrong PIN, enter correct PIN
  • Cancel the flow.
  • Select "Mobile", and observe that the device biometric / shema / PIN code screen is presented. It can be canceled.
    • Do all the possible test: cancel, enter wrong PIN, enter correct PIN
  • Cancel the flow.
  • Select "Desktop", and observe that the in-app PIN code screen is presented. It can be canceled.
    • Do all the possible test: cancel, enter wrong PIN, enter correct PIN
  • Cancel the flow.
  • Select "Mobile", and observe that the in-app PIN code screen is presented. It can be canceled.
    • Do all the possible test: cancel, enter wrong PIN, enter correct PIN

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bmarty bmarty added the PR-Wip For anything that isn't ready to ship and will be enabled at a later date label Jun 8, 2026
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/RYJqBB

@bmarty bmarty added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 9, 2026
@github-actions github-actions Bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Jun 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR-Wip For anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants