From f94d0163b54b84e2b5ee97d5f59a353c533482e9 Mon Sep 17 00:00:00 2001 From: Osamaali313 <86572800+Osamaali313@users.noreply.github.com> Date: Sun, 14 Jun 2026 16:50:57 +0300 Subject: [PATCH] fix(t5gemma): add missing f-prefix in _normalize_token error message The ValueError raised in t5gemma's _normalize_token used '{token!r}' inside a plain string literal (no f-prefix), so the message printed the literal text "{token!r}" instead of the offending token, making forbidden-token misconfigurations hard to debug. Add the f-prefix so the token is interpolated. Same bug class as #658 (gemma/gm/text/_sampler.py); this is the sibling occurrence in gemma/research/t5gemma/sampling.py. --- gemma/research/t5gemma/sampling.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gemma/research/t5gemma/sampling.py b/gemma/research/t5gemma/sampling.py index 3ea754b2..6819bab5 100644 --- a/gemma/research/t5gemma/sampling.py +++ b/gemma/research/t5gemma/sampling.py @@ -511,7 +511,7 @@ def _normalize_token(tokenizer, token: str | int) -> int: token_id = tokenizer.encode(token) if len(token_id) != 1: raise ValueError( - 'Invalid forbidden token: {token!r}. Forbidden tokens must map to' + f'Invalid forbidden token: {token!r}. Forbidden tokens must map to' ' single token ids in the vocab.' ) (token_id,) = token_id