Dogfood run unable to download artifact

[philderbeast]

Describe the bug

CI is hitting this issue actions/download-artifact#486.

Unable to download artifact(s): Failed to GetSignedArtifactURL: Received non-retryable error: Failed request
-- https://github.com/haskell/cabal/actions/runs/30026457823

One suggested fix is to match the versions of upload-artifact and download-artifact. The latest upload is v7 so this change would be ...

$ git diff
diff --git a/.github/workflows/validate.yml b/.github/workflows/validate.yml
index 6b06b0a32..84e15d10f 100644
--- a/.github/workflows/validate.yml
+++ b/.github/workflows/validate.yml
@@ -421,7 +421,7 @@ jobs:
           cabal-version: latest # default, we are not using it in this job
 
       - name: Download cabal executable from workflow artifacts
-        uses: actions/download-artifact@v8
+        uses: actions/download-artifact@v7
         with:
           name: cabal-${{ runner.os }}-${{ env.CABAL_ARCH }}
           path: cabal-head
@@ -445,7 +445,7 @@ jobs:
     needs: [validate, validate-old-ghcs, build-alpine, dogfooding]
 
     steps:
-      - uses: actions/download-artifact@v8
+      - uses: actions/download-artifact@v7
         with:
           pattern: cabal-*
           path: binaries
@@ -473,7 +473,7 @@ jobs:
     needs: [validate, validate-old-ghcs, build-alpine, dogfooding]
 
     steps:
-    - uses: actions/download-artifact@v8
+    - uses: actions/download-artifact@v7
       with:
         pattern: cabal-*
         path: binaries

Another suggested fix would be to match the run-id explicitly.

[philderbeast]

Here's what Copilot is suggesting:

Root cause: the job that failed is dogfooding, and it fails at “Download cabal executable from workflow artifacts” with:

• 404 Not Found: workflow run not found
• while trying to download artifact cabal-Linux-x86_64 from run 30026457823.

This indicates the download step is pointing at the wrong run context for the artifact lookup (the action is trying to resolve an artifact from a run ID that does not match the current workflow execution context visible to the download step).

Fix (workflow change)

In .github/workflows/validate.yml, update the dogfooding download step to fetch artifacts from the current workflow run explicitly.

Current step (around lines 423–427):

- name: Download cabal executable from workflow artifacts
  uses: actions/download-artifact@v8
  with:
    name: cabal-${{ runner.os }}-${{ env.CABAL_ARCH }}
    path: cabal-head

Suggested replacement:

- name: Download cabal executable from workflow artifacts
  uses: actions/download-artifact@v8
  with:
    name: cabal-${{ runner.os }}-${{ env.CABAL_ARCH }}
    path: cabal-head
    run-id: ${{ github.run_id }}
    github-token: ${{ secrets.GITHUB_TOKEN }}

Why this solves it

• The artifact is uploaded in the validate job in the same workflow run (lines 197–203).
• dogfooding depends on validate (needs: validate), so artifact availability is correct in principle.
• Explicitly binding download to ${{ github.run_id }} removes ambiguity in cross-run resolution and prevents the workflow run not found failure mode seen in the log.

Additional hardening (optional but recommended)

Pin both artifact actions to the same major generation pair known to work together in this repo. You currently use upload-artifact@v7 and download-artifact@v8; if intermittent behavior continues, align them (for example both to current stable major in your org’s standards), then retest.  

Source: .github/workflows/validate.yml  
https://github.com/haskell/cabal/blob/0c927405cbd3a1dda6180b503efacce21ef534ef/.github/workflows/validate.yml