Commit 2df159b
robustness: sync badge and status on ready-event error paths in tradeEventCallback (#255)
Two error paths in the 'ready' switch case called showErrorInPanel but
did not update the extension badge or popup status:
2. Parsed order array is empty after a 'ready' event
Both paths now call setBadge('!', BADGE_COLOR_ERROR) and reportStatus(ERROR)
after showErrorInPanel, making them consistent with all other error handling
in handleTradeReady and showApiError where every error updates all three
surfaces (panel, badge, popup status).
Without this fix the badge stayed blank and the popup showed stale status
(e.g. 'Active' from the last successful calculation) while the panel
displayed an error, leaving the user with a misleading overall state.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent 10c7811 commit 2df159b
1 file changed
Lines changed: 9 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
682 | 682 | | |
683 | 683 | | |
684 | 684 | | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
685 | 690 | | |
686 | 691 | | |
687 | 692 | | |
| |||
710 | 715 | | |
711 | 716 | | |
712 | 717 | | |
| 718 | + | |
| 719 | + | |
| 720 | + | |
| 721 | + | |
713 | 722 | | |
714 | 723 | | |
715 | 724 | | |
| |||
0 commit comments