You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
build(cython): drop platform_cimports.pxi workaround; keep IF/DEF usage consistent
Revert the fork-only partial IF/DEF conversions the CEF 147 modernization
introduced, per reviewer request (r3512025176): keep the codebase uniform on
IF; a complete IF/DEF migration is out of scope for this PR.
- Delete the fork-only src/platform_cimports.pxi and
src/extern/cef/platform_cimports.pxi (both absent from upstream cefpython147).
Restore upstream's inline per-file `IF UNAME_SYSNAME` platform cimports in
cefpython.pyx and cef_app/cef_browser/cef_browser_static/cef_platform.pxd,
plus the CEF 147 `cimport sandbox_linux`.
- utils.pyx: revert GetSystemError() to its original `IF UNAME_SYSNAME` form,
dropping the inline `cdef extern from *` C block.
- browser.pyx: restore `IF UNAME_SYSNAME == "Linux": cimport x11`.
- window_utils_win.pyx: restore the IsWindowHandle IF/ELSE guard.
Verified on Windows: clean build + 85/85 unit tests. Cython front-end also
transpiles clean for Linux and Darwin (forced via -E UNAME_SYSNAME); C++
compile/link on those platforms is left to CI.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
0 commit comments