From bb9181064ff50db657eaa46103aacd85923886fe Mon Sep 17 00:00:00 2001 From: Leonabcd123 <156839416+Leonabcd123@users.noreply.github.com> Date: Fri, 5 Jun 2026 21:50:40 +0300 Subject: [PATCH] impr(hotkeys): don't attach mod+shift+p hotkey on firefox --- frontend/src/ts/components/hotkeys/CommandlineHotkey.tsx | 3 ++- frontend/src/ts/input/hotkeys/commandline.ts | 9 +++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/frontend/src/ts/components/hotkeys/CommandlineHotkey.tsx b/frontend/src/ts/components/hotkeys/CommandlineHotkey.tsx index 82b583b81a0b..fd83fab991fb 100644 --- a/frontend/src/ts/components/hotkeys/CommandlineHotkey.tsx +++ b/frontend/src/ts/components/hotkeys/CommandlineHotkey.tsx @@ -1,5 +1,6 @@ import { Show } from "solid-js"; +import { nonFirefoxCommandlineHotkey } from "../../input/hotkeys/commandline"; import { hotkeys } from "../../states/hotkeys"; import { isFirefox } from "../../utils/misc"; import { Kbd } from "../common/Kbd"; @@ -10,7 +11,7 @@ export function CommandlineHotkey() {  or  - + ); diff --git a/frontend/src/ts/input/hotkeys/commandline.ts b/frontend/src/ts/input/hotkeys/commandline.ts index 0494cbbd5d7a..8a49ca5d80e7 100644 --- a/frontend/src/ts/input/hotkeys/commandline.ts +++ b/frontend/src/ts/input/hotkeys/commandline.ts @@ -1,12 +1,17 @@ import { hotkeys } from "../../states/hotkeys"; import { showModal } from "../../states/modals"; -import { isAnyPopupVisible } from "../../utils/misc"; +import { isAnyPopupVisible, isFirefox } from "../../utils/misc"; import { createHotkey } from "./utils"; +export const nonFirefoxCommandlineHotkey = "Mod+Shift+P"; + function openCommandline(): void { if (isAnyPopupVisible()) return; showModal("Commandline"); } createHotkey(() => hotkeys.commandline, openCommandline); -createHotkey("Mod+Shift+P", openCommandline); + +if (!isFirefox()) { + createHotkey(nonFirefoxCommandlineHotkey, openCommandline); +}