docs: add domain verification for org sso#23045
Conversation
ti-chi-bot
Bot
added
contribution
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the TiDB Cloud Organization SSO authentication documentation by adding a new section on adding and verifying domains for OIDC and SAML, and clarifying that configuring allowed email domains is required for these methods. The review feedback focuses on improving clarity, conciseness, and style-guide compliance. Key suggestions include rephrasing passive voice to active voice, simplifying wordy phrasing (such as changing 'according to your need' to 'as needed'), and correcting unidiomatic prepositions (such as changing 'locked out by' to 'locked out of').
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
|
||
| ### Add and verify domains for OIDC and SAML | ||
|
|
||
| Before configuring OIDC or SAML, add and verify the email domains that your organization members use to sign in. Only domains with the **Verified** status can be used in **Allowed Email Domains** for OIDC and SAML. |
There was a problem hiding this comment.
The sentence "Only domains with the Verified status can be used..." uses passive voice. Rephrasing it to active voice using the second person ("you") makes it more direct and easier to read.
| Before configuring OIDC or SAML, add and verify the email domains that your organization members use to sign in. Only domains with the **Verified** status can be used in **Allowed Email Domains** for OIDC and SAML. | |
| Before configuring OIDC or SAML, add and verify the email domains that your organization members use to sign in. You can only use domains with the **Verified** status in the **Allowed Email Domains** field for OIDC and SAML. |
References
- Avoid passive voice overuse and write in second person ('you') when addressing users. (link)
qiancai
added
translation/no-need
ti-chi-bot
Bot
removed
the
missing-translation-status
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
[LGTM Timeline notifier]Timeline:
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2 participants
Summary
Tests