From cf34df00a3b009ff33a01bf517945d5e69e9b363 Mon Sep 17 00:00:00 2001
From: QuantCode Agent <agent@quantcode.dev>
Date: Sun, 14 Jun 2026 16:50:27 +0000
Subject: [PATCH] fix: repair cross-package bugs and test env to make suite
 pass

- api.ts: import renamed useDebounce hook (was stale useThrottle)
- Button: forward aria-label to the rendered button element
- DataTable: use functional state updater to fix stale-closure sort toggle
- date.ts: use dateStyle:'short' so en-AU yields day-first dates
- bunfig.toml / packages/ui/bunfig.toml: apply happy-dom env + preload for component tests
- tsconfig.json: register bun-types so tsc resolves bun:test globals
---
 apps/web/src/lib/api.ts                            | 5 ++---
 bunfig.toml                                        | 3 ++-
 packages/ui/bunfig.toml                            | 1 +
 packages/ui/src/components/Button/Button.tsx       | 4 ++--
 packages/ui/src/components/DataTable/DataTable.tsx | 2 +-
 packages/utils/src/format/date.ts                  | 6 +-----
 tsconfig.json                                      | 1 +
 7 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/apps/web/src/lib/api.ts b/apps/web/src/lib/api.ts
index 2d4731b..e9e0a52 100644
--- a/apps/web/src/lib/api.ts
+++ b/apps/web/src/lib/api.ts
@@ -7,8 +7,7 @@
  * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -29,4 +28,4 @@ export async function fetchPosts() {
 export { formatDate, formatAUD }
 
 // Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+export { useDebounce as useSearchDebounce }
diff --git a/bunfig.toml b/bunfig.toml
index 3258d71..26b14f2 100644
--- a/bunfig.toml
+++ b/bunfig.toml
@@ -1,2 +1,3 @@
 [test]
-environment = "happy-dom"
\ No newline at end of file
+environment = "happy-dom"
+preload = ["./packages/ui/test/setup.ts"]
\ No newline at end of file
diff --git a/packages/ui/bunfig.toml b/packages/ui/bunfig.toml
index 54ef11c..db99b08 100644
--- a/packages/ui/bunfig.toml
+++ b/packages/ui/bunfig.toml
@@ -1,2 +1,3 @@
 [test]
+environment = "happy-dom"
 preload = ["./test/setup.ts"]
\ No newline at end of file
diff --git a/packages/ui/src/components/Button/Button.tsx b/packages/ui/src/components/Button/Button.tsx
index af65c97..2a35b1d 100644
--- a/packages/ui/src/components/Button/Button.tsx
+++ b/packages/ui/src/components/Button/Button.tsx
@@ -34,13 +34,13 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const resolvedAriaLabel = ariaLabel ?? (iconOnly ? "button" : undefined)
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}
diff --git a/packages/ui/src/components/DataTable/DataTable.tsx b/packages/ui/src/components/DataTable/DataTable.tsx
index 429a6e3..fb5b629 100644
--- a/packages/ui/src/components/DataTable/DataTable.tsx
+++ b/packages/ui/src/components/DataTable/DataTable.tsx
@@ -31,7 +31,7 @@ export function DataTable<T extends Record<string, unknown>>({ data, columns }:
   // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir(prev => prev === "asc" ? "desc" : "asc")
     } else {
       setSortKey(key)
       setSortDir("asc")
diff --git a/packages/utils/src/format/date.ts b/packages/utils/src/format/date.ts
index 609e46c..35fa808 100644
--- a/packages/utils/src/format/date.ts
+++ b/packages/utils/src/format/date.ts
@@ -11,11 +11,7 @@
  */
 export function formatDate(date: Date): string {
   // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  return new Intl.DateTimeFormat("en-AU", { dateStyle: "short" }).format(date)
 }
 
 export function formatDateTime(date: Date): string {
diff --git a/tsconfig.json b/tsconfig.json
index 167f910..8e00ae0 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -6,6 +6,7 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]