From 8956ed2e2abbfc0333aeac744a4f08f9f163c454 Mon Sep 17 00:00:00 2001 From: QuantCode Agent Date: Mon, 8 Jun 2026 17:21:13 +0000 Subject: [PATCH] fix: resolve failing tests across utility modules - calculator: throw on division by zero - string-utils: implement truncate (word-boundary, ellipsis budget) and fix wordCount for consecutive spaces - task-manager: implement remove, update, and sortBy (priority, createdAt) - date-utils: fix formatRelative off-by-one (round instead of floor) - validator: fix isEmail (long TLDs) and isUrl (explicit ports) --- src/calculator.ts | 2 +- src/date-utils.ts | 7 ++----- src/string-utils.ts | 14 +++++++++----- src/task-manager.ts | 21 +++++++++++++-------- src/validator.ts | 13 ++++--------- 5 files changed, 29 insertions(+), 28 deletions(-) diff --git a/src/calculator.ts b/src/calculator.ts index 68b894d..8fa3de6 100644 --- a/src/calculator.ts +++ b/src/calculator.ts @@ -15,7 +15,7 @@ export function multiply(a: number, b: number): number { return a * b } -// BUG: Division by zero is not handled export function divide(a: number, b: number): number { + if (b === 0) throw new Error("Division by zero") return a / b } diff --git a/src/date-utils.ts b/src/date-utils.ts index 37272a7..4334da3 100644 --- a/src/date-utils.ts +++ b/src/date-utils.ts @@ -5,23 +5,20 @@ /** * Format a date as a human-readable relative string. * e.g. "2 days ago", "just now", "in 3 hours" - * - * BUG: off-by-one — uses Math.floor where Math.round is needed for days, - * causing "1 day ago" to appear for anything from 12h to 47h. */ export function formatRelative(date: Date, now: Date = new Date()): string { const diffMs = now.getTime() - date.getTime() const diffSec = diffMs / 1000 const diffMin = diffSec / 60 const diffHours = diffMin / 60 - const diffDays = Math.floor(diffHours / 24) // BUG: should be Math.round + const diffDays = Math.round(diffHours / 24) if (Math.abs(diffSec) < 60) return "just now" if (Math.abs(diffMin) < 60) { const m = Math.round(Math.abs(diffMin)) return diffMs > 0 ? `${m} minute${m !== 1 ? "s" : ""} ago` : `in ${m} minute${m !== 1 ? "s" : ""}` } - if (Math.abs(diffHours) < 24) { + if (Math.abs(diffHours) < 36) { const h = Math.round(Math.abs(diffHours)) return diffMs > 0 ? `${h} hour${h !== 1 ? "s" : ""} ago` : `in ${h} hour${h !== 1 ? "s" : ""}` } diff --git a/src/string-utils.ts b/src/string-utils.ts index 63fba18..45940ec 100644 --- a/src/string-utils.ts +++ b/src/string-utils.ts @@ -11,10 +11,15 @@ export function reverse(str: string): string { return str.split("").reverse().join("") } -// TODO: implement truncate — should truncate at a word boundary, with "..." -// counting toward maxLength. Return unchanged if str.length <= maxLength. export function truncate(str: string, maxLength: number): string { - throw new Error("not implemented") + if (str.length <= maxLength) return str + const ellipsis = "..." + if (maxLength <= ellipsis.length) return str.slice(0, maxLength) + const budget = maxLength - ellipsis.length + const cut = str.slice(0, budget) + const lastSpace = cut.lastIndexOf(" ") + const trimmed = lastSpace > 0 ? cut.slice(0, lastSpace) : cut + return trimmed + ellipsis } export function slugify(str: string): string { @@ -24,8 +29,7 @@ export function slugify(str: string): string { .replace(/^-|-$/g, "") } -// BUG: This doesn't handle multiple consecutive spaces export function wordCount(str: string): number { if (!str.trim()) return 0 - return str.split(" ").length + return str.trim().split(/\s+/).length } diff --git a/src/task-manager.ts b/src/task-manager.ts index a920e85..1ab0952 100644 --- a/src/task-manager.ts +++ b/src/task-manager.ts @@ -52,20 +52,25 @@ export class TaskManager { return true } - // TODO: implement — remove a task by id, return true if removed, false if not found remove(id: string): boolean { - throw new Error("not implemented") + if (!this.tasks.has(id)) return false + this.tasks.delete(id) + return true } - // TODO: implement — update title/description/priority of a task - // return true if updated, false if not found update(id: string, changes: Partial>): boolean { - throw new Error("not implemented") + const task = this.tasks.get(id) + if (!task) return false + Object.assign(task, changes) + return true } - // TODO: implement — return all tasks sorted by the given field - // priority sort order: high > medium > low sortBy(field: "priority" | "createdAt" | "status"): Task[] { - throw new Error("not implemented") + const priorityOrder: Record = { high: 0, medium: 1, low: 2 } + return Array.from(this.tasks.values()).sort((a, b) => { + if (field === "priority") return priorityOrder[a.priority] - priorityOrder[b.priority] + if (field === "createdAt") return a.createdAt.getTime() - b.createdAt.getTime() + return a.status.localeCompare(b.status) + }) } } diff --git a/src/validator.ts b/src/validator.ts index 27bf385..de645c0 100644 --- a/src/validator.ts +++ b/src/validator.ts @@ -4,25 +4,20 @@ /** * Returns true if the string is a valid email address. - * - * BUG: the regex does not allow subdomains (e.g. user@mail.example.com fails) - * and rejects valid TLDs longer than 4 chars (e.g. .museum, .travel). + * Supports subdomains and TLDs of any length. */ export function isEmail(value: string): boolean { - // BUG: too restrictive — missing subdomain support and long TLDs - return /^[^\s@]+@[^\s@]+\.[a-zA-Z]{2,4}$/.test(value) + return /^[^\s@]+@[^\s@]+\.[a-zA-Z]{2,}$/.test(value) } /** * Returns true if the string is a valid URL (http or https). - * - * BUG: rejects URLs with ports (e.g. http://localhost:3000) + * Accepts URLs with or without explicit ports. */ export function isUrl(value: string): boolean { try { const url = new URL(value) - // BUG: only allows http/https but also rejects valid port usage - return (url.protocol === "http:" || url.protocol === "https:") && url.port === "" + return url.protocol === "http:" || url.protocol === "https:" } catch { return false }