OpenSSL download fails on Windows

[christianrauch]

Description

Recently, the action fails to download OpenSSL on Windows:

  openssl v3.3.1 [Approved]
  openssl package files install completed. Performing other installation steps.
  Attempt to get headers for https://slproweb.com/download/Win64OpenSSL-3_3_1.exe failed.
    The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://slproweb.com/download/Win64OpenSSL-3_3_1.exe'. Exception calling "GetResponse" with "0" argument(s): "The remote server returned an error: (404) Not Found."
  Downloading openssl 64 bit
    from 'https://slproweb.com/download/Win64OpenSSL-3_3_1.exe'
  ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url 'https://slproweb.com/download/Win64OpenSSL-3_3_1.exe'. 

The URL https://slproweb.com/download/Win64OpenSSL-3_3_1.exe (OpenSSL 3.3.1) returns a 404 while https://slproweb.com/download/Win64OpenSSL-3_3_2.exe (OpenSSL 3.3.2) works.

Expected Behavior

The action should download OpenSSL without issues.

Actual Behavior

The action fails with the above error.

System (please complete the following information)

• OS: Windows on GitHub runner
• ROS 2 Distro: jazzy

[christophebedard]

Can you share a link to a workflow that fails?

I don't think we provide/use that URL anywhere in setup-ros. We just rely on chocolatey to install OpenSSL:

setup-ros/src/package_manager/chocolatey.ts

Line 10 in a6ce30e

const chocoDependencies: string[] = ["wget", "7zip", "lcov", "openssl"];

. I'm guessing something broke on their side. Looks like it's now using 3.3.2, so it might be fixed now: https://community.chocolatey.org/packages/OpenSSL.

[christianrauch]

This looks like a caching or sync issue. Now it downloads the newest version 3.3.2:

openssl v3.3.2 [Approved]
openssl package files install completed. Performing other installation steps.
Downloading openssl 64 bit
  from 'https://slproweb.com/download/Win64OpenSSL-3_3_2.exe'

Download of Win64OpenSSL-3_3_2.exe (216.73 MB) completed.

The problem was that choco still had the URL for the older version 3.3.1, but that archive was removed when OpenSSL was updated to 3.3.2. It seems to take a while until choco updates the URLs.

Is there a way to prevent these things from happening when a package is updated and the old version is removed?

[christophebedard]

Sorry, I have no idea. This is more of a chocolatey issue than a setup-ros issue.