From 35a658a341b2e2ec54d628165f71442cd2c8466f Mon Sep 17 00:00:00 2001 From: fjtirado Date: Fri, 12 Jun 2026 17:29:53 +0200 Subject: [PATCH] Wait timeouttest refinement Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: fjtirado --- .../impl/test/WaitExecutorTest.java | 25 +++---------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java b/impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java index 3895f9f8c..2c110dbf1 100644 --- a/impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java +++ b/impl/test/src/test/java/io/serverlessworkflow/impl/test/WaitExecutorTest.java @@ -55,7 +55,8 @@ static void tearDown() { // ========== DurationInline Tests ========== @Test - @Disabled("This one slow down") + @Disabled( + "Disabled because it waits 1s and slows the suite; DSL mapping is covered by testWaitSecondsConvenienceMethod") void testWaitWithDurationInlineSeconds() { Workflow workflow = WorkflowBuilder.workflow("wait-inline-seconds", "test", "0.1.0") @@ -87,7 +88,6 @@ void testWaitWithDurationInlineMilliseconds() { @Test void testWaitWithDurationInlineComposite() { - // Test composite duration with multiple components Workflow workflow = WorkflowBuilder.workflow("wait-inline-composite", "test", "0.1.0") .tasks(DSL.wait(Duration.ofMillis(100).plusMillis(100))) @@ -98,7 +98,7 @@ void testWaitWithDurationInlineComposite() { long elapsed = System.currentTimeMillis() - startTime; assertThat(model).isNotNull(); - assertThat(elapsed).isGreaterThanOrEqualTo(200); // 1 second + 500 milliseconds + assertThat(elapsed).isGreaterThanOrEqualTo(200); } // ========== DurationLiteral Tests (TimeoutAfter.durationLiteral) ========== @@ -122,25 +122,6 @@ void testWaitWithDurationLiteralISO8601Seconds() { assertThat(elapsed).isGreaterThanOrEqualTo(1000); } - @Test - void testWaitWithDurationLiteralISO8601Composite() { - Workflow workflow = - WorkflowBuilder.workflow("wait-literal-composite", "test", "0.1.0") - .tasks( - list -> - list.wait( - w -> - w.build().setWait(new TimeoutAfter().withDurationExpression("PT0.1S")))) - .build(); - - long startTime = System.currentTimeMillis(); - WorkflowModel model = appl.workflowDefinition(workflow).instance(Map.of()).start().join(); - long elapsed = System.currentTimeMillis() - startTime; - - assertThat(model).isNotNull(); - assertThat(elapsed).isGreaterThanOrEqualTo(100); - } - @Test void testWaitWithDurationLiteralISO8601Milliseconds() { // PT0.1S = 100 milliseconds