Add GPU support#20
Merged
Merged
Conversation
Update the Dockerfile and documentation to support running the Insta360 media SDK tools with and without an NVIDIA GPU. - Simplify installation of the media SDK in Dockerfile - Update README.md to support both cases (with and without GPU) - Remove start.sh It's trivial to write a host-side script for building and running the Docker container. We provide the recipe in README.md, and will not provide the starting script.
This is so that one can use git clean -df to clean up datadir/
Update `README.md` to add a tip for cleaning up `datadir/`. Tweak `.gitignore` to remove `datadir/**` from the list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the Docker-based Insta360 CLI workflow to support both CPU-only and NVIDIA GPU processing, while keeping the older MediaSDK as the default for machines without a GPU.
MEDIASDK_UBUNTU_DEBbuild argument, while defaulting to the older 2.0-6 package for CPU-only use. Updates.gitignorefor the new.debfilename anddatadir/.apt installof the.deb). Trims unnecessary build dependencies from the intermediate 3.1.x upgrade in favor of a leaner image that works with either SDK version.--runtime=nvidia --gpus all), including one-time setup of the NVIDIA Container Toolkit.join-insv— Removes an existing output file before callingexiftool, avoiding failures on re-runs.docker run/docker buildexamples, andjoin-insvusage (including--is_57kfor 5.7K). Container startup is documented in the README rather than via a helper script.Test plan
MEDIASDK_UBUNTU_DEB=libMediaSDK-dev-3.1.1.0-20250922_191110-amd64.debon a machine with an NVIDIA GPU--runtime=nvidia --gpus alland confirm GPU-accelerated processingjoin-insvon 4K and 5.7K inputs; verify re-running with the same output path succeeds