Skip to content

[Feature Request] opt out of watching deprecated crds #413

Description

@robcao

Is your feature request related to a problem? Please describe.

The TemporalWorkerDeployment and TemporalConnection CRDs were deprecated, but the worker controller currently still watches these resources (for backwards compatibility reasons). Newer users of the worker controller do not want to install these deprecated CRDs, and receive a bunch of errors like this when these deprecated CRDs aren't installed. I would like to have a flag exposed that opts out of these watch streams.

if kind is a CRD, it should be installed before calling Start
"no matches for kind \"TemporalConnection\" in version \"temporal.io/v1alpha1\""
"no matches for kind \"TemporalWorkerDeployment\" in version \"temporal.io/v1alpha1\""

Due to code like this:

https://github.com/temporalio/temporal-worker-controller/blob/main/cmd/main.go#L111
https://github.com/temporalio/temporal-worker-controller/blob/main/internal/controller/worker_controller.go#L886

Describe the solution you'd like

Expose a configuration flag like WATCH_DEPRECATED_CRDS that when set to false (true could be the default value if not set), opts out of these watches. Naming can be flexible of course

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions