Consider this issue as reopening #5 (I'm not allowed to reopen it, so I created a new issue).
Back then, I submitted a pull request to make siphash a proper java module: #4. This was merged (4ebf457), but for some reason converted into an automatic module (9ecae58). At the time I thought this was sort of ok, but this issue made me aware of that it actually is a really bad idea.
See for example also this:
https://issues.apache.org/jira/browse/MCOMPILER-293 -> "It's fine to declare and use explicit modules that require automatic modules in limited settings, but they should never be published to Maven Central or any similar public repository."
I'm not sure why automatic module was chosen instead of a proper module; as siphash is not having any dependencies itself, transforming it into a proper module is easy, has no disadvantages that I can think of, and will make others happy ;-).
Therefore a friendly request to still make this change.
Consider this issue as reopening #5 (I'm not allowed to reopen it, so I created a new issue).
Back then, I submitted a pull request to make siphash a proper java module: #4. This was merged (4ebf457), but for some reason converted into an automatic module (9ecae58). At the time I thought this was sort of ok, but this issue made me aware of that it actually is a really bad idea.
See for example also this:
https://issues.apache.org/jira/browse/MCOMPILER-293 -> "It's fine to declare and use explicit modules that require automatic modules in limited settings, but they should never be published to Maven Central or any similar public repository."
I'm not sure why automatic module was chosen instead of a proper module; as siphash is not having any dependencies itself, transforming it into a proper module is easy, has no disadvantages that I can think of, and will make others happy ;-).
Therefore a friendly request to still make this change.