fix(5e-SRD-spell.ts): Modify Spell damage schema and add multi damage type support#1190
Open
JuCJeff wants to merge 1 commit into
Open
fix(5e-SRD-spell.ts): Modify Spell damage schema and add multi damage type support#1190JuCJeff wants to merge 1 commit into
JuCJeff wants to merge 1 commit into
Conversation
JuCJeff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This modified the damage schema for spells to an array of objects instead of an object. This change helps support spells with multiple damage types and is following the convention of the monster damage schema.
As part of this PR a few things are being modified:
Changes schema from an object of
SpellDamageSchemato an array of the object schemaConverted all existing spell damages to the array of objects format in
src/2014/en/5e-SRD-Spells.jsonandsrc/2014/fr-FR/5e-SRD-Spells.jsonModified 3 specific spells that does multi-type damages:
How was it tested?
Ran
npm test src/2014/tests/schemas.test.tsand passed ✅Is there a Github issue this is resolving?
#558 (comment)
Did you update the docs in the API? Please link an associated PR if applicable.
Have not done that. Will need further input on what this entails @bagelbits
Here's a fun image for your troubles