fix: fitall button and clicking per file should output identical results

[PinkShnack]

Issue from #47

Todo:

• update changelog
• make sure outputs are the same for normal and KVM models
• make sure the output in the tsv file is the same

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.96%. Comparing base (d087a97) to head (cb34383).

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
- Coverage   67.98%   67.96%   -0.03%     
==========================================
  Files          36       36              
  Lines        2824     2831       +7     
==========================================
+ Hits         1920     1924       +4     
- Misses        904      907       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[PinkShnack]

Hey @paulmueller: Stephanie and Jana need some changes. Please especially look at the readme section regarding use of AI. Thoughts on that?

[PinkShnack]

When trying to compare whether the outputted TSV file is identical, three small bugs were found and corrected (by claude). They might be the fix to the issues we had with KVM and caching. More tests are needed. Here are the changes from claude:

• 1 (fit_update_parameters, tab_fit.py:358): When switching models, the old params_initial (e.g., Hertz's "E" key) was passed to the new model's get_parm_name(), which threw a KeyError. Fix: detect model change via prev_model_key and fall back to fresh fit_parameters() when the model changes.

• 2 (fit_update_parameters, tab_fit.py:363): Nanite's _anc_cache gets set to {'max_indent': ...} after the first (Hertz) fit. When the model switches to KVM, anc_update_parameters calls get_ancillary_parameters() which returns this stale Hertz-only cache — so anc_used = [], the ancillary table stays empty, and time_ind is never applied to itab. Fix: clear fdist._anc_cache when the model changes.

• 3 (anc_update_parameters, tab_fit.py:120): Setting itab.item(rr, 1).setText(value) inside anc_update_parameters (without signal blocking) fired on_params_init → recursive anc_update_parameters → nested atab.blockSignals(False) calls unblocked atab prematurely, causing chaotic state. Fix: wrap the itab.item.setText() call in itab.blockSignals(True/False).

[paulmueller]

It would take me a bit longer to get back into the code and understand the changes.
Have you understood and verified the proposed changes?
I think it is not necessary to mention the use of AI in the readme. You can mention the use of AI in a commit (we can do that in the squash-merge-commit).
Ultimately, it is your commit and LLMs are just tools.

[PinkShnack]

Have you understood and verified the proposed changes?

Yes I do, the main changes make sure that clicking each one by one and clicking the "fit all" button output the same thing. I've checked with the GUI and the unit tests also do this.
The other main change made was that, when changing the model, the default (initial) params sometimes got overwritten by the previous model. Now the cache is cleared correctly when changing to a new model. I had noticed this during #43 and claude now found out where the issue was and fixed it.

I think it is not necessary to mention the use of AI in the readme. You can mention the use of AI in a commit (we can do that in the squash-merge-commit). Ultimately, it is your commit and LLMs are just tools.

I agree, we will include it in the merge commit message!

Please have a look. The code-cov is failing, but it seems to be because coverage doesn't "run" the new comment lines.

I want to get this version released for Stephanie and Jana, as they were the ones who noticed that clicking and the button outputted differently!