Move NNX state reconstruction and Linen conversion helpers to train_state_nnx.py.#4374
Open
copybara-service[bot] wants to merge 1 commit into
Open
Move NNX state reconstruction and Linen conversion helpers to train_state_nnx.py.#4374copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
suexu1025,
vipannalla and
xibinliu
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_944118451
branch
2 times, most recently
from
640e027 to
19cb8ec
Compare
…tate_nnx.py. This change refactors the MaxText checkpointing logic by moving helper functions for NNX state reconstruction and Linen checkpoint format conversion from `checkpointing.py` to `train_state_nnx.py`. The affected functions include `default_for_sds`, `populate_pure_dict_from_partial`, and `rebuild_nnx_with_values`. Corresponding unit tests have also been expanded in `train_state_nnx_test.py`. PiperOrigin-RevId: 944118451
copybara-service
Bot
force-pushed
the
test_944118451
branch
from
19cb8ec to
eacda55
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move NNX state reconstruction and Linen conversion helpers to train_state_nnx.py.
This change refactors the MaxText checkpointing logic by moving helper functions for NNX state reconstruction and Linen checkpoint format conversion from
checkpointing.pytotrain_state_nnx.py. The affected functions includedefault_for_sds,populate_pure_dict_from_partial, andrebuild_nnx_with_values. Corresponding unit tests have also been expanded intrain_state_nnx_test.py.