Use helper functions for CheckpointManager operations.#4383
Open
copybara-service[bot] wants to merge 1 commit into
Open
Use helper functions for CheckpointManager operations.#4383copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
requested review from
A9isha,
NicoGrande,
NuojCheng,
RissyRan,
SurbhiJainUSC,
abhinavclemson,
aireenmei,
bvandermoon,
darisoy,
dipannita08,
gagika,
gobbleturk,
hengtaoguo,
igorts-git,
jiangjy1982,
khatwanimohit,
parambole,
richjames0,
shralex,
shuningjin,
suexu1025,
vipannalla,
xibinliu and
xuefgu
as code owners
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
copybara-service
Bot
force-pushed
the
test_944311356
branch
3 times, most recently
from
b5fcfc2 to
df99772
Compare
Refactors code to interact with the CheckpointManager through dedicated helper functions instead of direct method calls. This is necessary because: - The underlying CheckpointManager operations (`.wait_until_finished`, `.latest_step`, `.reached_preemption`) have different semantics in v1 compared to v0. - We need to ensure the v0 emergency checkpointer functionality remains intact. This abstraction layer isolates the core logic from the specific CheckpointManager version PiperOrigin-RevId: 944311356
copybara-service
Bot
force-pushed
the
test_944311356
branch
from
df99772 to
952e375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use helper functions for CheckpointManager operations.
Refactors code to interact with the CheckpointManager through dedicated helper functions instead of direct method calls. This is necessary because:
.wait_until_finished,.latest_step,.reached_preemption) have different semantics in v1 compared to v0.This abstraction layer isolates the core logic from the specific CheckpointManager version