Skip to content

Fix incorrect sharding for TSP, DP, fused_mlp workloads #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dinodeep wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix incorrect sharding for TSP, DP, fused_mlp workloads #4385

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/maxtext/layers/linears.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,11 @@ def __call__(
activations = []
if cfg.fused_mlp:
x = self.wi(inputs, out_sharding=intermediate_sharding)

# Enforce fused activations don't shard on num_activations axis
fused_intermediate_logical = self.intermediate_logical[:2] + (None,) + self.intermediate_logical[2:]
x = self._maybe_shard_with_logical(x, fused_intermediate_logical)

x = checkpoint_name(x, "mlpwi")
for idx, act_fn in enumerate(self.activations):
y = _convert_to_activation_function(act_fn)(x[:, :, idx, ...])
Expand Down
Loading