Fix RL LR schedule default#4392
Open
AntonyMei wants to merge 1 commit into
Open
Conversation
RL computes its real training length from num_batches, rl.num_iterations, train_fraction, and num_epoch, but rl.yml inherited base.yml steps=150001. Config normalization then converted learning_rate_schedule_steps=-1 into that inherited step count before the RL optimizer saw max_train_steps, causing warmup/decay to use a much longer horizon than the actual RL run. Set both steps and learning_rate_schedule_steps to -1 in the RL base config so the optimizer falls back to the computed max_train_steps unless a recipe explicitly pins the schedule horizon. Also warn when a positive learning_rate_schedule_steps differs from the computed RL training length, since that may be intentional but is easy to inherit accidentally.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RL computes its real training length from num_batches, rl.num_iterations, train_fraction, and num_epoch, but rl.yml inherited base.yml steps=150001. Config normalization then converted learning_rate_schedule_steps=-1 into that inherited step count before the RL optimizer saw max_train_steps, causing warmup/decay to use a much longer horizon than the actual RL run.
Set both steps and learning_rate_schedule_steps to -1 in the RL base config so the optimizer falls back to the computed max_train_steps unless a recipe explicitly pins the schedule horizon. Also warn when a positive learning_rate_schedule_steps differs from the computed RL training length, since that may be intentional but is easy to inherit accidentally.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.