Split TPU and GPU nightly image builds to run E2E tests in parallel:#4398
Draft
chiajunglien wants to merge 1 commit into
Draft
Split TPU and GPU nightly image builds to run E2E tests in parallel:#4398chiajunglien wants to merge 1 commit into
chiajunglien wants to merge 1 commit into
Conversation
- Split the single `build_and_push_docker_image` matrix job into parallel `build_and_push_tpu_docker_images` and `build_and_push_gpu_docker_images` jobs. - Update `run_e2e_tests` to depend only on the TPU builds, allowing the Airflow E2E tests to trigger immediately after TPU pre/post-training images are pushed. - Ensure GPU CI tests run in parallel with the Airflow E2E tests, drastically reducing overall pipeline runtime. - Correct the `maxtext_sha` reference to use the correct job ID `build_maxtext_package`. - Update `notify_failure` to monitor both build jobs and the E2E tests.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_and_push_docker_imagematrix job into parallelbuild_and_push_tpu_docker_imagesandbuild_and_push_gpu_docker_imagesjobs.run_e2e_teststo depend only on the TPU builds, allowing the Airflow E2E tests to trigger immediately after TPU pre/post-training images are pushed.maxtext_shareference to use the correct job IDbuild_maxtext_package.notify_failureto monitor both build jobs and the E2E tests.Description
Start with a short description of what the PR does and how this is a change from
the past.
The rest of the description includes relevant details and context, examples:
If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/123456
FIXES: #123456
You can also provide a comma-separated list. If you don't want to close a bug but
simply to reference it, use BUGS, e.g.:
BUGS: b/123456
Notice 1: Once all tests pass, the "pull ready" label will automatically be assigned.
This label is used for administrative purposes. Please do not add it manually.
Notice 2: For external contributions, our settings currently require an approval from a MaxText maintainer to trigger CI tests.
Tests
Please describe how you tested this change, and include any instructions and/or
commands to reproduce.
Checklist
Before submitting this PR, please make sure (put X in square brackets):
gemini-reviewlabel.