feat(wallet_screening): paginate Etherscan txlist and surface warnings (#214)#215
Conversation
|
Hey @Hendobox, thanks for picking up another clean #115 slice. A small tip before merge, would be nice to have a line in I’ll update the pinned #115 comment to mark #214 / #215 as in review under Ph 2.2b (slice). Happy to merge once CI is green. Nice work continuing the RFC pattern from #128 / #140. <3 |
|
Thanks @rosspeili — added the catalog note in |
|
@Hendobox Thanks for the quick follow-up, This looks tight, I only see a conflict on changelog since we had 2 releases cut today, but it's a quick rebase fix. Also in terms of data schema, maybe add optional Once CI is green on the rebased branch, we’re good to merge. Thanks for continuing to this RFC and web3 area of Skillware bro <3 |
|
@Hendobox how you've been? This might need another rebase, and address the above after 0.4.5. Happy to rereview and merge your next commit when done, then will sort the trackers on the rfc. |
ARPAHLS#214) Fetch account txlist in pages (cap 10k txs), emit metadata.warnings when history is truncated or unavailable, and add mocked bundle tests plus agent instructions. Part of ARPAHLS#115.
…PAHLS#214) Update catalog Limitations so operators see pagination caps and metadata.warnings without reading instructions.md first.
… items Resolve CHANGELOG against 0.4.5+, add optional metadata.warnings to the catalog JSON example, and bump skill version to 1.0.1 for the user-visible report shape change (schema v2 stays for later ARPAHLS#115 work).
|
Hey @rosspeili — thanks for the nudge. Rebased onto latest
Local wallet_screening tests: 18 passed. Happy for another look once CI is green. 🙏 |
482d8ab to
f95e853
Compare
Summary
account.txlist(1k per page, cap 10k txs)metadata.warningswhen history is truncated or unavailableinstructions.mdand bundle tests (mocked only)Fixes #214 · Part of #115
Test plan
pytest skills/finance/wallet_screening/test_skill.py tests/skills/finance/test_wallet_screening.py -q(18 passed)flake8+blackon changed files