feat(bg_remover): harden skill to v0.2.0#268
Open
AyushSrivastava1818 wants to merge 2 commits into
Open
Conversation
Signed-off-by: AyushSrivastava1818 <ayush.sri0705@gmail.com>
Contributor
|
Thanks for the clean branch, much better than #266, I will close 266 and track here. This is closer on the runtime core (session cache, basic validation, 25 MB limit, mkdir for Still missing / fix
Bump is fine as |
26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens the
creative/bg_removerskill to v0.2.0 by improving robustness, validation, and documentation.Fixes #257
Changes
output_path.Type of Change
skills/Checklist (all PRs)
Fixes #257)python -m black --check .andflake8pass locally (or CI-equivalent subset)pytest skills/andpytest tests/pass locally when relevantCHANGELOG.mdupdated under[Unreleased]when user-visible behavior changesexamples/README.mdupdated if this PR adds, renames, or removes a runnable scriptpytest tests/test_registry_docs.pywhen skills, examples index, or agent-loops matrix changedNew or updated skill
skills/<category>/<skill_name>/(fromtemplates/python_skill/or equivalent)manifest.yaml:name,version,description,parameters,constitution, realissuerskill.py(no ad-hoc LLM-generated execution paths)instructions.mdexplains when and how to use the skillcard.jsonissuer matches manifest when presenttest_skill.pycovers execution and schema expectationsdocs/skills/README.mdand row indocs/skills/README.mdConstitution and safety
This update improves input validation and filesystem safety by validating Base64 input and image files, rejecting missing, directory, empty, oversized (>25 MB), and invalid images, reusing cached rembg sessions, and automatically creating parent directories for
output_path.Related Issues
Fixes #257