Add a GitHub CI to check sorting HttpsExclusions#596
Open
piquark6046 wants to merge 15 commits into
Open
Conversation
zloyden
approved these changes
Jun 14, 2024
piquark6046
changed the title
Member
|
In this case, all lines will be sorted, including comments
|
scripthunter7
suggested changes
Jun 25, 2024
scripthunter7
left a comment
scripthunter7
left a comment
There was a problem hiding this comment.
I left some comments, please take a look
Co-authored-by: scripthunter7 <d.tota@adguard.com>
scripthunter7
approved these changes
Jun 25, 2024
scripthunter7
approved these changes
Jun 25, 2024
scripthunter7
left a comment
scripthunter7
left a comment
There was a problem hiding this comment.
lgtm
cc @Alex-302 I think you can merge it
Alex-302
reviewed
Jun 25, 2024
| branches: | ||
| - master | ||
| paths: | ||
| - "**/*.txt" |
Member
There was a problem hiding this comment.
Both "**/*.txt" can be replaced by a relative path of banks.txt?
Member
Author
There was a problem hiding this comment.
Sure, But, it can be extended in the future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does not have
lint-stagednpm package to check the ordering at only GitHub-hosted workflow runner automatically.If the CI finds any incorrect ordering in
banks.txtfile, the workflow run will be failed. Otherwise, the workflow run will be succeeded.