Skip to content

docs(agent-workflows): correct the MCP flag name across docs#5231

Merged
mmabrouk merged 1 commit into
big-agentsfrom
docs/mcp-flag-sweep
Jul 11, 2026
Merged

docs(agent-workflows): correct the MCP flag name across docs#5231
mmabrouk merged 1 commit into
big-agentsfrom
docs/mcp-flag-sweep

Conversation

@mmabrouk

Copy link
Copy Markdown
Member

Symptom

Six pages of the agent-workflows documentation describe a security-relevant feature flag under a name that does not exist in the code. They cite AGENTA_AGENT_ENABLE_MCP for the gate that controls user-declared MCP server resolution. A reader who sets that variable gets no effect, and a reader grepping the code for it finds nothing.

Ground truth (verified at origin/big-agents tip, post #5225)

The real flag is AGENTA_AGENT_MCPS_ENABLED, and it defaults OFF. Confirmed unanimous across every layer:

  • SDK gate: sdks/python/agenta/sdk/agents/handler.py:104os.getenv("AGENTA_AGENT_MCPS_ENABLED", "") (empty default -> off)
  • Service gate: services/oss/src/agent/tools/resolver.py:24os.getenv("AGENTA_AGENT_MCPS_ENABLED", "") (off; [feat] Reuse Daytona sandboxes across turns instead of deleting them every turn #5225 reverted a stale "true" here)
  • Compose: ${AGENTA_AGENT_MCPS_ENABLED:-false} in all OSS/EE stacks
  • Helm: hosting/kubernetes/helm/templates/_helpers.tpl:331default false $runner.enableMcp
  • Env examples: # AGENTA_AGENT_MCPS_ENABLED=false

So the docs' only error was the flag name; the "off by default" polarity they already stated was correct and is preserved.

Pages fixed (name-only change, polarity unchanged)

  • documentation/adapters/claude-code.md
  • documentation/agent-configuration.md
  • documentation/architecture.md
  • documentation/ground-truth.md
  • documentation/ports-and-adapters.md
  • documentation/tools.md (3 occurrences)

Note

documentation/running-the-agent.md was investigated and deliberately left out: its big-agents version already uses the correct name and Default false. A "Default true" variant appears only in the entangled local workspace tree (unmerged keep-alive lanes), not on the target branch, so no change is needed here.

https://claude.ai/code/session_018MaXPNpvzN22kngHno3VMj

@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 11, 2026
@vercel

vercel Bot commented Jul 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
agenta-documentation Ready Ready Preview, Comment Jul 11, 2026 8:06pm

Request Review

@dosubot dosubot Bot added the documentation Improvements or additions to documentation label Jul 11, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e87d7a2b-4317-40da-babc-7dd0ebe95090

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/mcp-flag-sweep

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mmabrouk
mmabrouk merged commit fe7d6bb into big-agents Jul 11, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant