docs(agent-workflows): correct the MCP flag name across docs#5231
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Symptom
Six pages of the agent-workflows documentation describe a security-relevant feature flag under a name that does not exist in the code. They cite
AGENTA_AGENT_ENABLE_MCPfor the gate that controls user-declared MCP server resolution. A reader who sets that variable gets no effect, and a reader grepping the code for it finds nothing.Ground truth (verified at
origin/big-agentstip, post #5225)The real flag is
AGENTA_AGENT_MCPS_ENABLED, and it defaults OFF. Confirmed unanimous across every layer:sdks/python/agenta/sdk/agents/handler.py:104—os.getenv("AGENTA_AGENT_MCPS_ENABLED", "")(empty default -> off)services/oss/src/agent/tools/resolver.py:24—os.getenv("AGENTA_AGENT_MCPS_ENABLED", "")(off; [feat] Reuse Daytona sandboxes across turns instead of deleting them every turn #5225 reverted a stale"true"here)${AGENTA_AGENT_MCPS_ENABLED:-false}in all OSS/EE stackshosting/kubernetes/helm/templates/_helpers.tpl:331—default false $runner.enableMcp# AGENTA_AGENT_MCPS_ENABLED=falseSo the docs' only error was the flag name; the "off by default" polarity they already stated was correct and is preserved.
Pages fixed (name-only change, polarity unchanged)
documentation/adapters/claude-code.mddocumentation/agent-configuration.mddocumentation/architecture.mddocumentation/ground-truth.mddocumentation/ports-and-adapters.mddocumentation/tools.md(3 occurrences)Note
documentation/running-the-agent.mdwas investigated and deliberately left out: itsbig-agentsversion already uses the correct name andDefault false. A "Default true" variant appears only in the entangled local workspace tree (unmerged keep-alive lanes), not on the target branch, so no change is needed here.https://claude.ai/code/session_018MaXPNpvzN22kngHno3VMj