docs(design): plan docker sandbox provider + sandboxes allowlist#5285
docs(design): plan docker sandbox provider + sandboxes allowlist#5285junaway wants to merge 1 commit into
Conversation
…owlist Two follow-on projects to the sandbox-agent refactor, built on its seams: - projects/docker-sandbox: a docker provider (per-session containers instead of parked host processes), folding in the persistent-sessions PoC learnings and adding the container naming/label/GC conventions the PoC lacked. - projects/allowed-sandboxes: AGENTA_RUNNER_SANDBOXES_ALLOWLIST, a per-deployment provider allowlist enforced at every layer, generalizing AGENTA_SANDBOX_LOCAL_ALLOWED. - addendum on the refactor plan linking both and noting the pre-rename paths. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds two new design-plan documents that extend the sandbox provider “axis” (introducing a proposed docker provider and a cross-layer sandbox allowlist), and links them back to the earlier sandbox-agent refactor plan so future implementation work has a clear roadmap and seam references.
Changes:
- Added a detailed plan for a
dockersandbox provider (per-session containers, naming/labels, GC, keep-alive/pooling, and deployment surface considerations). - Added a plan for
AGENTA_RUNNER_SANDBOXES_ALLOWLISTto gate allowed sandbox providers across runner/services/api/web/hosting, with clear precedence vs.AGENTA_SANDBOX_LOCAL_ALLOWED. - Updated the sandbox-agent refactor plan with an addendum linking to these follow-on plans and noting the
services/agent→services/runnerrename.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docs/design/agent-workflows/projects/sandbox-agent-refactor/sandbox-agent-refactor-plan.md | Adds an addendum linking the refactor seams to the new docker/allowlist follow-on plans and clarifying path rename context. |
| docs/design/agent-workflows/projects/docker-sandbox/docker-sandbox-plan.md | New design plan for a docker sandbox provider, including lifecycle, naming/labels, GC, durable cwd options, and testing slices. |
| docs/design/agent-workflows/projects/allowed-sandboxes/allowed-sandboxes-plan.md | New design plan for a deployment-level sandbox provider allowlist enforced consistently across layers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Context
Two follow-on design docs for the sandbox axis, built on the seams the sandbox-agent refactor (#5264) extracted, and folding in the docker mode learnings from the persistent-sessions PoC (#4813).
What
docs/design/agent-workflows/projects/docker-sandbox/docker-sandbox-plan.md— adockersandbox provider: one container per session on the runner's Docker daemon, parked viadocker stopin the existing session pool instead of the PoC's fresh-container-per-turn. Adds what the PoC lacked: a deterministic container naming convention (<runner-container-name>-sandbox-<fingerprint-hash>),agenta.sandbox.*labels as the discovery/GC/re-adoption index, boot + periodic sweeps (the PoC leaked containers), and a durable-cwd recommendation (host bind-mount over per-container FUSE caps).docs/design/agent-workflows/projects/allowed-sandboxes/allowed-sandboxes-plan.md—AGENTA_RUNNER_SANDBOXES_ALLOWLIST, a comma-separated per-deployment provider allowlist generalizingAGENTA_SANDBOX_LOCAL_ALLOWED(kept as a deprecated restrictive-wins alias). Enforced at every layer: runnerbuildRunPlan(authoritative, fail-closed) +buildSandboxProviderbackstop, services/oss generalized gate, apiRunnerConfig, web__env.js→ dropdown filter, hosting/helm. Cloud setsdaytona; self-host stays unset (all allowed).projects/sandbox-agent-refactor/sandbox-agent-refactor-plan.mdlinking both plans and noting its pre-renameservices/agentpaths.Both plans carry an explicit deployment-surface checklist (env
*.examplefiles, compose blocks, helm schema/values/helpers/values example, self-host configuration MDX).Notes
AGENTA_SERVICES_CODE_SANDBOX_RUNNER: SDK registryrestrictedvs documentedlocal) was fixed directly onbig-agentsin2d539c653c.🤖 Generated with Claude Code