[chore] Revert ts dep bumps from #5337#5358
Conversation
[release] v0.105.2
This reverts the web dependency bumps from PR #5337 (merge commit 22900cf), restoring the pre-PR versions across the web workspace, including the source reformatting its "run hooks" commit applied. The services/runner half of #5337 (daytona SDK, OTel, undici) was already reverted on main by 019f24b, 7a3190a and the two subsequent revert commits, so this change is confined to web/. web/pnpm-lock.yaml is restored verbatim from before the PR rather than regenerated. A fresh resolve would re-float every caret-ranged dep back to the versions the PR installed (prettier ^3.7.4 resolves to 3.9.5 today), which reverts the manifests but not the actual dependency tree. @playwright/test is deliberately left pinned at 1.60.0 (a35eb91) rather than restored to the pre-PR "^1.60.0" range, which would float to 1.61.x and reintroduce the Node 22.15+/24 async loader failure fixed in e3bb3e6. The later playwright locator fixes (2f81c12, e3bb3e6) are likewise untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR refreshes web workspace dependency declarations, changes internal package references to the ChangesWeb dependency and workspace alignment
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Railway Preview Environment
|
There was a problem hiding this comment.
🧹 Nitpick comments (2)
web/packages/agenta-entities/src/runnable/utils.ts (1)
829-831: 📐 Maintainability & Code Quality | 🔵 TrivialRun the required frontend lint-fix before committing.
Please run
pnpm lint-fixfrom thewebfolder; the supplied validation mentionsturbo lint, but does not confirm this required command.As per coding guidelines, frontend changes require running
pnpm lint-fixwithin thewebfolder before committing.Source: Coding guidelines
web/oss/package.json (1)
22-134: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winMove
@agenta/web-teststodevDependencies. It’s only imported from the Playwright test suite underweb/oss/tests/playwright/acceptance, so it doesn’t belong in the runtime dependency set;web/ee/package.jsonalready places it indevDependencies.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 440d2323-1642-4b12-96c9-fc1b0e42a7ef
⛔ Files ignored due to path filters (1)
web/pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (108)
web/ee/package.jsonweb/oss/package.jsonweb/oss/src/components/AgentChatSlice/AgentConversation.tsxweb/oss/src/components/AgentChatSlice/assets/trace.tsweb/oss/src/components/EvalRunDetails/atoms/mutations/editEvaluation.tsweb/oss/src/components/EvalRunDetails/atoms/runMetrics.tsweb/oss/src/components/EvalRunDetails/atoms/table/types.tsweb/oss/src/components/EvalRunDetails/components/views/OverviewView/hooks/useRunMetricData.tsweb/oss/src/components/EvalRunDetails/utils/buildAnnotationMetricData.tsweb/oss/src/components/EvaluationRunsTablePOC/components/EvaluationRunsTable/index.tsxweb/oss/src/components/Evaluators/components/ConfigureEvaluator/index.tsxweb/oss/src/components/Filters/Filters.tsxweb/oss/src/components/InfiniteVirtualTable/atoms/columnVisibility.tsweb/oss/src/components/InfiniteVirtualTable/columns/createStandardColumns.tsxweb/oss/src/components/InfiniteVirtualTable/hooks/useHeaderViewportVisibility.tsweb/oss/src/components/Playground/Components/Modals/RefinePromptModal/hooks/useRefinePrompt.tsweb/oss/src/components/Playground/Components/PlaygroundFocusDrawerAdapter/index.tsxweb/oss/src/components/Playground/Playground.tsxweb/oss/src/components/Playground/PlaygroundTokenPath/atoms.tsweb/oss/src/components/SharedDrawers/AnnotateDrawer/assets/hooks/useEvaluatorSchemas.tsweb/oss/src/components/SharedDrawers/AnnotateDrawer/assets/transforms.tsweb/oss/src/components/SharedDrawers/TraceDrawer/store/traceDrawerStore.tsweb/oss/src/components/Sidebar/engine/SidebarMenu.tsxweb/oss/src/components/Webhooks/WebhookDrawer.tsxweb/oss/src/components/Webhooks/assets/types.tsweb/oss/src/components/WorkflowRevisionDrawerWrapper/index.tsxweb/oss/src/components/pages/observability/assets/filters/referenceUtils.tsweb/oss/src/lib/helpers/analytics/hooks/useSurvey.tsweb/oss/src/lib/hooks/useAnnotations/types/index.tsweb/oss/src/lib/hooks/usePreviewEvaluations/assets/previewRunBatcher.tsweb/oss/src/services/app-selector/api/index.tsweb/oss/src/state/appCreation/status.tsweb/oss/src/state/newObservability/atoms/controls.tsweb/oss/src/state/workflow/destinations.tsweb/package.jsonweb/packages/agenta-annotation-ui/package.jsonweb/packages/agenta-annotation/package.jsonweb/packages/agenta-annotation/src/state/controllers/annotationSessionController.tsweb/packages/agenta-api-client/package.jsonweb/packages/agenta-entities/package.jsonweb/packages/agenta-entities/src/loadable/controller.tsweb/packages/agenta-entities/src/runnable/evaluatorTransforms.tsweb/packages/agenta-entities/src/runnable/types.tsweb/packages/agenta-entities/src/runnable/utils.tsweb/packages/agenta-entities/src/shared/execution/schema.tsweb/packages/agenta-entities/src/shared/openapi/schemaUtils.tsweb/packages/agenta-entities/src/shared/relations/extendWithRelations.tsweb/packages/agenta-entities/src/shared/tableTypes.tsweb/packages/agenta-entities/src/testcase/state/molecule.tsweb/packages/agenta-entities/src/workflow/api/createFromTemplate.tsweb/packages/agenta-entities/src/workflow/core/evaluatorResolution.tsweb/packages/agenta-entities/src/workflow/snapshotAdapter.tsweb/packages/agenta-entities/src/workflow/state/appUtils.tsweb/packages/agenta-entities/src/workflow/state/commit.tsweb/packages/agenta-entities/src/workflow/state/molecule.tsweb/packages/agenta-entities/src/workflow/state/runnableSetup.tsweb/packages/agenta-entities/src/workflow/state/store.tsweb/packages/agenta-entity-ui/package.jsonweb/packages/agenta-entity-ui/src/DrillInView/SchemaControls/FeedbackConfigurationControl.tsxweb/packages/agenta-entity-ui/src/DrillInView/SchemaControls/PromptSchemaControl.tsxweb/packages/agenta-entity-ui/src/DrillInView/SchemaControls/ToolItemControl.tsxweb/packages/agenta-entity-ui/src/DrillInView/SchemaControls/ToolSelectorPopover.tsxweb/packages/agenta-entity-ui/src/DrillInView/SchemaControls/agentTemplate/useAgentTools.tsweb/packages/agenta-entity-ui/src/DrillInView/SchemaControls/agentTemplate/useModelHarness.tsxweb/packages/agenta-entity-ui/src/DrillInView/components/PlaygroundConfigSection.tsxweb/packages/agenta-entity-ui/src/adapters/variantAdapters.tsweb/packages/agenta-entity-ui/src/modals/actions/types.tsweb/packages/agenta-entity-ui/src/modals/types.tsweb/packages/agenta-entity-ui/src/selection/adapters/createAdapterFromRelations.tsweb/packages/agenta-entity-ui/src/selection/adapters/createLevelFromRelation.tsweb/packages/agenta-entity-ui/src/selection/components/UnifiedEntityPicker/types.tsweb/packages/agenta-entity-ui/src/selection/hooks/modes/autoSelectLatestChild.tsweb/packages/agenta-entity-ui/src/view-types/viewTypes.tsweb/packages/agenta-playground-ui/package.jsonweb/packages/agenta-playground-ui/src/components/ExecutionItemComparisonView/GenerationComparisonCompletionOutput/index.tsxweb/packages/agenta-playground-ui/src/components/ExecutionItems/assets/ChatTurnView/index.tsxweb/packages/agenta-playground-ui/src/components/ExecutionItems/assets/ExecutionRow/ComparisonLayout.tsxweb/packages/agenta-playground-ui/src/components/ExecutionItems/assets/ExecutionRow/SingleLayout.tsxweb/packages/agenta-playground-ui/src/components/PlaygroundOutputs/index.tsxweb/packages/agenta-playground-ui/src/components/WorkflowRevisionDrawer/store.tsweb/packages/agenta-playground-ui/src/components/shared/EvaluatorFieldGrid/index.tsxweb/packages/agenta-playground-ui/src/components/shared/NodeResultCard/index.tsxweb/packages/agenta-playground/package.jsonweb/packages/agenta-playground/src/state/atoms/modeOverride.tsweb/packages/agenta-playground/src/state/controllers/playgroundController.tsweb/packages/agenta-playground/src/state/controllers/playgroundSnapshotController.tsweb/packages/agenta-playground/src/state/controllers/traceRefResolution.tsweb/packages/agenta-playground/src/state/execution/agentRequest.tsweb/packages/agenta-playground/src/state/execution/executionItems.tsweb/packages/agenta-playground/src/state/execution/executionRunner.tsweb/packages/agenta-playground/src/state/helpers/entityInputContract.tsweb/packages/agenta-sdk/package.jsonweb/packages/agenta-shared/package.jsonweb/packages/agenta-shared/src/utils/chatMessage.tsweb/packages/agenta-shared/src/utils/elicitation.tsweb/packages/agenta-shared/src/utils/mappingUtils.tsweb/packages/agenta-shared/src/utils/mustache/parser.tsweb/packages/agenta-shared/src/utils/schemaOptions.tsweb/packages/agenta-ui/package.jsonweb/packages/agenta-ui/src/ChatMessage/components/ChatInputs.tsxweb/packages/agenta-ui/src/Editor/form/nodes/ObjectNode.tsxweb/packages/agenta-ui/src/InfiniteVirtualTable/atoms/columnVisibility.tsweb/packages/agenta-ui/src/InfiniteVirtualTable/columns/createStandardColumns.tsxweb/packages/agenta-ui/src/InfiniteVirtualTable/hooks/useHeaderViewportVisibility.tsweb/packages/agenta-ui/src/drill-in/coreTypes.tsweb/packages/agenta-ui/src/utils/styles.tsweb/pnpm-workspace.yamlweb/tests/package.json
💤 Files with no reviewable changes (1)
- web/pnpm-workspace.yaml
The revert of PR #5337 removed the `overrides` block from web/pnpm-workspace.yaml along with the ts dep bumps, without mentioning it. Restoring pnpm-lock.yaml verbatim to the pre-PR state re-floated three packages below the floors those overrides enforced: vite (8.0.12 < ^8.0.16), postcss bundled inside next (8.4.31 < >=8.5.10), and minimatch via an old typescript-eslint dev dependency (9.0.3 < >=9.0.7). Re-adds the overrides and re-locks just enough to satisfy them, without re-floating the caret-ranged deps (prettier etc.) the revert intentionally pinned. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Context
PR #5337 bumped the TypeScript dependencies across the web workspace. This takes those
bumps back out.
The
services/runnerhalf of #5337 (daytona SDK, OTel, undici) was already reverted onmain by the walk-backs at 019f24b and 7a3190a, so what was left is confined to
web/.Changes
Reverts the web dependency bumps from #5337 (merge commit 22900cf): the package
manifests, the lockfile, and the source reformatting that its "run hooks" commit applied
when prettier went from 3.7.4 to 3.9.5.
web/pnpm-lock.yamlis restored verbatim from before the PR rather than regenerated.This is the part worth knowing: deleting the lockfile and reinstalling does not revert a
dependency bump. A fresh resolve re-reads every caret range and picks whatever is newest
today, which is mostly what the PR installed (
"prettier": "^3.7.4"resolves straightback to 3.9.5). Regenerating reverted only 73 of the 454 package versions #5337
introduced. Restoring the file verbatim reverts all 454.
Two later fixes are deliberately kept rather than reverted:
@playwright/teststays pinned at exactly1.60.0(a35eb91). Restoring the pre-PR^1.60.0range would float to 1.61.x and reintroduce the Node 22.15+/24 async loaderfailure that e3bb3e6 fixed.
Notes
pnpm iagainst the restored lockfile downgrades cleanly: prettier 3.9.5 to 3.7.4,tsx 4.23.1 to 4.22.4, typescript-eslint 8.64.0 to 8.61.0, next 15.5.20 to 15.5.18.
turbo lintpasses and the prettier hook is a no-op, which confirms the formattingrevert is consistent with 3.7.4.
pnpm ion the newer tree: reinstall after thismerges, or your next commit will reformat those files back.