Skip to content

Localization option added#2

Open
JBraunsmaJr wants to merge 9 commits into
mainfrom
localization
Open

Localization option added#2
JBraunsmaJr wants to merge 9 commits into
mainfrom
localization

Conversation

@JBraunsmaJr

@JBraunsmaJr JBraunsmaJr commented Dec 23, 2021

Copy link
Copy Markdown
Contributor

Added localization to our template.

This requires an update from the DCS library before getting merged

@JBraunsmaJr JBraunsmaJr added the enhancement New feature or request label Dec 23, 2021
@JBraunsmaJr JBraunsmaJr requested a review from Lulalaby December 23, 2021 22:21
@JBraunsmaJr JBraunsmaJr self-assigned this Dec 23, 2021
Lulalaby
Lulalaby requested changes Dec 24, 2021
View reviewed changes

@Lulalaby Lulalaby left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments shouldn't be here XD

Comment thread src/Content/DisCatSharpProjectBot/translations/my_simple_command.json Outdated
Comment thread src/Content/DisCatSharpProjectBot/translations/my_simple_command.json Outdated
Comment thread src/Content/DisCatSharpSolution/DisCatSharpProjectBot/translations/my_simple_command.json Outdated
Comment thread src/Content/DisCatSharpSolution/DisCatSharpProjectBot/translations/my_simple_command.json Outdated
@Lulalaby Lulalaby added the on-hold This won't be merged for now label Dec 24, 2021
JBraunsmaJr and others added 4 commits December 24, 2021 00:21
@JBraunsmaJr @Lulalaby
Update src/Content/DisCatSharpSolution/DisCatSharpProjectBot/translat…
12f28ac 
…ions/my_simple_command.json

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
@JBraunsmaJr @Lulalaby
Update src/Content/DisCatSharpProjectBot/translations/my_simple_comma…
3b64a40 
…nd.json

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
@JBraunsmaJr @Lulalaby
Update src/Content/DisCatSharpProjectBot/translations/my_simple_comma…
8ce1495 
…nd.json

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
@JBraunsmaJr @Lulalaby
Update src/Content/DisCatSharpSolution/DisCatSharpProjectBot/translat…
0c565c2 
…ions/my_simple_command.json

Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
@JBraunsmaJr

JBraunsmaJr commented Dec 24, 2021

Copy link
Copy Markdown
Contributor Author

Yeaaaaaaa.... I just copied from docs lol

@Lulalaby Lulalaby self-requested a review December 27, 2021 02:01
@JBraunsmaJr

JBraunsmaJr commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

Not sure how I feel about a project template targeting nightly builds. Is it possible that we move to a concept such as "preview" or "release candidate" work flows?

Could be safer as it involves "updating" on consumer end and less "breaking" changes that could be implemented overnight.

@Lulalaby

Lulalaby commented Sep 5, 2022

Copy link
Copy Markdown
Member

Not sure how I feel about a project template targeting nightly builds. Is it possible that we move to a concept such as "preview" or "release candidate" work flows?

Could be safer as it involves "updating" on consumer end and less "breaking" changes that could be implemented overnight.

For now the latest nightly is the most stable we have, it's actually a release candidate.
I would prefer using that at least for now

@Lulalaby Lulalaby removed the on-hold This won't be merged for now label Sep 16, 2022
@Lulalaby

Lulalaby commented Sep 16, 2022

Copy link
Copy Markdown
Member

Ready to go

@Lulalaby Lulalaby marked this pull request as ready for review September 16, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lulalaby Lulalaby Awaiting requested review from Lulalaby

Requested changes must be addressed to merge this pull request.

Assignees

@JBraunsmaJr JBraunsmaJr

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JBraunsmaJr @Lulalaby