feat: Add missing application fields (event webhooks, flags_new)#850
Draft
sentry[bot] wants to merge 1 commit into
Draft
feat: Add missing application fields (event webhooks, flags_new)#850sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue of missing properties in the
TransportApplicationmodel when deserializing Discord API responses for applications. Discord's/applications/@meendpoint now returns additional fields that were not previously mapped, leading to warnings in the logs.Specifically, this PR:
ApplicationEventWebhooksStatusto represent the status of event webhooks.event_webhooks_url,event_webhooks_status, andevent_webhooks_typesproperties toTransportApplication.cswith appropriate[JsonProperty]attributes.DiscordApplicationentity.flags_newis already correctly mapped inTransportApplication.cs(though it was missing in older releases, it's present on main).These changes ensure that DisCatSharp correctly deserializes the full application payload from Discord, preventing warnings about unhandled properties and making the new data accessible to developers.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist:
@Aiko-IT-Systems/discatsharp-reviewer
Fixes DISCATSHARP-2HG