Skip to content

feat: Update TransportApplication with new Discord API fields#854

Draft
sentry[bot] wants to merge 1 commit into
mainfrom
seer/feat/application-event-webhooks
Draft

feat: Update TransportApplication with new Discord API fields#854
sentry[bot] wants to merge 1 commit into
mainfrom
seer/feat/application-event-webhooks

Conversation

@sentry

@sentry sentry Bot commented May 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR addresses the 'Found missing properties in api response for TransportApplication' Sentry warning (DISCATSHARP-2GV).

Discord's API now includes new fields for Application objects related to event webhooks and an updated flags_new field. These missing properties were causing warnings due to DiscordJson detecting unmapped fields.

Changes include:

  • Retyping TransportApplication.FlagsNew from ApplicationFlags? to string? to correctly handle Discord's string representation of the bitfield, which can exceed JavaScript's safe integer range. The DiscordApplication constructor now parses this string into ApplicationFlags.
  • Adding [JsonProperty] members to TransportApplication.cs for event_webhooks_url (string), event_webhooks_status (new ApplicationEventWebhookStatus enum), and event_webhooks_types (list of strings).
  • Introducing a new enum ApplicationEventWebhookStatus to represent the status of event webhooks.
  • Propagating these new properties to the public DiscordApplication entity, making them accessible to users of the library.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

No specific testing details were provided in the PR description.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@Aiko-IT-Systems/discatsharp-reviewer

Fixes DISCATSHARP-2GV

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

0 participants