feat: Update TransportApplication with new Discord API fields#854
Draft
sentry[bot] wants to merge 1 commit into
Draft
feat: Update TransportApplication with new Discord API fields#854sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the 'Found missing properties in api response for TransportApplication' Sentry warning (DISCATSHARP-2GV).
Discord's API now includes new fields for Application objects related to event webhooks and an updated
flags_newfield. These missing properties were causing warnings due toDiscordJsondetecting unmapped fields.Changes include:
TransportApplication.FlagsNewfromApplicationFlags?tostring?to correctly handle Discord's string representation of the bitfield, which can exceed JavaScript's safe integer range. TheDiscordApplicationconstructor now parses this string intoApplicationFlags.[JsonProperty]members toTransportApplication.csforevent_webhooks_url(string),event_webhooks_status(newApplicationEventWebhookStatusenum), andevent_webhooks_types(list of strings).ApplicationEventWebhookStatusto represent the status of event webhooks.DiscordApplicationentity, making them accessible to users of the library.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
No specific testing details were provided in the PR description.
Test Configuration:
Checklist:
@Aiko-IT-Systems/discatsharp-reviewer
Fixes DISCATSHARP-2GV