Skip to content

[O2B-1577] Rename include.byName filter to permittedNonPhysicsNames#2128

Merged
graduta merged 5 commits into
mainfrom
improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName
May 27, 2026
Merged

[O2B-1577] Rename include.byName filter to permittedNonPhysicsNames#2128
graduta merged 5 commits into
mainfrom
improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 9, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • The include.byName filter is now called permittedNonPhysicsNames
  • The first ~30 lines of code in datapassService.getAll have been refactored for readability

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 9, 2026
@NarrowsProjects NarrowsProjects requested a review from graduta as a code owner April 9, 2026 14:06
@NarrowsProjects NarrowsProjects added backend javascript Pull requests that update Javascript code labels Apr 9, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.88%. Comparing base (469ef0f) to head (c576760).

Files with missing lines Patch % Lines
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 1 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 1 Missing ⚠️
...ataPasses/ActiveColumns/dataPassesActiveColumns.js 0.00% 1 Missing ⚠️
lib/server/controllers/dataPasses.controller.js 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2128   +/-   ##
=======================================
  Coverage   45.88%   45.88%           
=======================================
  Files        1035     1035           
  Lines       17167    17165    -2     
  Branches     3124     3123    -1     
=======================================
  Hits         7877     7877           
+ Misses       9290     9288    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects force-pushed the improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName branch from 893ed68 to 18fb34c Compare May 26, 2026 14:27
Comment thread lib/server/services/dataPasses/DataPassService.js Outdated
Comment thread lib/server/controllers/dataPasses.controller.js Outdated
@graduta graduta merged commit 7a03dd1 into main May 27, 2026
41 of 42 checks passed
@graduta graduta deleted the improv/O2B-1577/Rename-the-include.byName-filter-in-data-passes-overview-model-to-includeName branch May 27, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

2 participants