Skip to content

[O2B-1558] Set filters from url upon page reload#2144

Open
NarrowsProjects wants to merge 18 commits into
mainfrom
feature/O2B-1558/Set-filters-from-URL-upon-page-reload
Open

[O2B-1558] Set filters from url upon page reload#2144
NarrowsProjects wants to merge 18 commits into
mainfrom
feature/O2B-1558/Set-filters-from-URL-upon-page-reload

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 27, 2026

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When a filters on overview pages are set, the active filters will appear in the url, when reloading the page, these filters will be applied automatically.

Notable changes for developers:

  • N/A

Changes made to the database:

  • N/A

@NarrowsProjects NarrowsProjects self-assigned this Apr 27, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

❌ Patch coverage is 46.72131% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.94%. Comparing base (1443e47) to head (6add680).

Files with missing lines Patch % Lines
lib/public/views/Runs/Overview/RunsWithQcModel.js 0.00% 15 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 10 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 9 Missing ⚠️
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 5 Missing ⚠️
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 4 Missing ⚠️
...mulationPass/RunsPerSimulationPassOverviewModel.js 0.00% 4 Missing ⚠️
lib/server/Loggers/FilterLogger.js 78.57% 3 Missing ⚠️
...ataPasses/ActiveColumns/dataPassesActiveColumns.js 0.00% 2 Missing ⚠️
...c/views/LhcFills/Overview/LhcFillsOverviewModel.js 0.00% 2 Missing ⚠️
lib/server/Loggers/index.js 0.00% 2 Missing ⚠️
... and 9 more
Additional details and impacted files
@@                                                             Coverage Diff                                                             @@
##           impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel    #2144      +/-   ##
===========================================================================================================================================
+ Coverage                                                                                                    45.91%   45.94%   +0.03%     
===========================================================================================================================================
  Files                                                                                                         1035     1037       +2     
  Lines                                                                                                        17170    17245      +75     
  Branches                                                                                                      3126     3135       +9     
===========================================================================================================================================
+ Hits                                                                                                          7883     7924      +41     
- Misses                                                                                                        9287     9321      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@NarrowsProjects NarrowsProjects changed the base branch from main to impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel April 27, 2026 07:50
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1558/Set-filters-from-URL-upon-page-reload branch 4 times, most recently from 82c8d41 to e157e08 Compare April 29, 2026 08:41
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 4 times, most recently from bc70145 to beca3c1 Compare May 7, 2026 17:51
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from beca3c1 to 319bb4d Compare May 11, 2026 06:50
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1558/Set-filters-from-URL-upon-page-reload branch from a49f1bd to 767f763 Compare May 25, 2026 16:22
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1558/Set-filters-from-URL-upon-page-reload branch from 767f763 to 6add680 Compare May 25, 2026 16:50
Base automatically changed from impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel to main May 26, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

1 participant