fix: preserve Android EaseView visuals on drop and add example#47
Open
MeliValesca wants to merge 2 commits into
Open
fix: preserve Android EaseView visuals on drop and add example#47MeliValesca wants to merge 2 commits into
MeliValesca wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an Android issue where
EaseViewbackgrounds could disappear during react-native-screens / Expo Router screen transitions after a view was dropped.The problem was that Android called full
cleanup()fromonDropViewInstance, which reset visual properties like background color, transforms, opacity, borders, and elevation while the outgoing native view could still be visible during the transition. The fix splits lifecycle cleanup so dropping a view stops animation work without clearing its last rendered visual state, while full reset still happens when the view is prepared for recycling.Also adds an Issue #45 repro screen to the example app to manually verify animated background, style background, and active animation behavior during navigation transitions.
Test Plan
Reproduced the bug with the code given in this issue. #45
Issues→Issue #45 — Android modal backgroundScreen.Recording.2026-06-11.at.4.13.23.PM.mov
Verified the same repro manually on iOS using the example app horizontal card transition.
Ran:
yarn format:check yarn lint yarn test --runInBandAll checks passed.