Respect relative/absolute CMAKE_INSTALL_INCLUDEDIR#209
Open
r-burns wants to merge 1 commit into
Open
Conversation
CMAKE_INSTALL_INCLUDEDIR is already used in some places, but not consistently, causing headers to be installed to multiple locations when it is specified differently from the default "include" value. Additionally, upstream GNUInstallDirs documentations notes that install dirs may be specified as relative (to install prefix) or absolute paths, so we should only append to the install prefix when non-absolute paths are given.
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CMAKE_INSTALL_INCLUDEDIR is already used in some places, but not consistently, causing headers to be installed to multiple locations when it is specified differently from the default "include" value.
Additionally, upstream GNUInstallDirs documentation notes that install dirs may be specified as relative (to install prefix) or absolute paths, so we should only append to the install prefix when non-absolute paths are given.