Stardew Valley: Fixed filler buffs only rolling one of each instead of as many as needed#6293
Open
agilbert1412 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
waiting-on: peer-review
agilbert1412
added
the
is: bug/fix
Jouramie
approved these changes
Jun 27, 2026
Jouramie
left a comment
Jouramie
left a comment
Collaborator
There was a problem hiding this comment.
Woops that's probably my fault.
LGTM
Jouramie
added
waiting-on: core-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Fixes a bug where player buff items weren't properly qualified as fillers that can be duplicated, and as a result, multiworlds only rolled one of each at most, even if there was plenty of room in the item pool
How was this tested?
Unit test, plus used a yaml that disables all other filler, to confirm that it indeed generates many of each