Skip to content

Reset semantic element margins for Figma geometry#601

Merged
chubes4 merged 1 commit into
trunkfrom
fix/figma-semantic-margin-reset
Jul 14, 2026
Merged

Reset semantic element margins for Figma geometry#601
chubes4 merged 1 commit into
trunkfrom
fix/figma-semantic-margin-reset

Conversation

@chubes4

@chubes4 chubes4 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Finalized Homeboy agent-task cook run agent-task-211d0007-fda1-4d79-b223-8f8367c92de6 into review-ready branch fix/figma-semantic-margin-reset.

Proof provenance

  • Proof runner: Homeboy agent-task cook loop
  • Proof ID: agent-task-finalization:agent-task-211d0007-fda1-4d79-b223-8f8367c92de6
  • Homeboy run ID: agent-task-211d0007-fda1-4d79-b223-8f8367c92de6
  • Manual proof: none recorded by this Homeboy finalization

Publication intent

  • Schema: homeboy/agent-task-publication-intent/v1
  • Action: review_request
  • Target kind: code_review
  • Adapter: github_pull_request
  • Base: trunk
  • Head: fix/figma-semantic-margin-reset

Source refs

Source relationship

  • Related finding ID: none recorded
  • Source packet ID: none recorded
  • Change kind: runtime-fix
  • Supersedes: none recorded
  • Depends on: none recorded

Runtime guardrails

  • Why this is not broader than the packet evidence: Production reset is limited to blockquote UA margins; generated class margins remain more specific.
  • Evidence discriminators preserved: blockquote in vertical stack with preceding/following siblings
  • Nearby contracts preserved: explicit generated margin and sibling geometry remain authoritative

Attempt summary

Forensic candidate strengthened after independent test review; PHP and browser geometry contracts green.

Gate results

  • contract-tests: passed (targeted)
  • browser-geometry: passed (targeted)
  • independent-review: passed (targeted)

Verification capability

  • targeted_checks_run: composer --working-dir=figma-transformer test, npm test --prefix php-transformer/tools/visual-parity
  • targeted_checks_unavailable: none recorded
  • ci_expected: none recorded
  • manual_reviewer_check: none recorded

CI-equivalent coverage

  • CI-equivalent required gate: CI-equivalent required gate was not recorded; targeted proof must not be treated as full CI coverage

Changed files

  • figma-transformer/src/Html/HtmlArtifactAssembler.php
  • php-transformer/tools/visual-parity/package.json
  • php-transformer/tools/visual-parity/tests/blockquote-margin-reset.mjs
  • php-transformer/tools/visual-parity/tests/fixtures/blockquote-margin-reset.scenegraph.json

Artifact refs

  • none recorded

Final status

  • Status: review-ready
  • Base: trunk
  • Head: fix/figma-semantic-margin-reset
  • Merge/deploy: not performed

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode via Homeboy
  • Model: openai/gpt-5.6-sol
  • Used for: Implemented blockquote margin normalization from landed FSE DOM evidence with browser-computed proof.

@chubes4 chubes4 merged commit 55bb0ca into trunk Jul 14, 2026
1 check passed
@chubes4 chubes4 deleted the fix/figma-semantic-margin-reset branch July 14, 2026 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant