Fix paragraph save-shape regressions#605
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #604.
Summary
style.dimensions.maxWidthfromcore/paragraphcomment attributes and rendered markup.be-inline-geometry-*carrier stylesheet.10-nonprofit,13-realistic-small-business, and74-lumen-coffee.Why
Gutenberg paragraph
save()does not reproducedimensions.maxWidth. Blocks Engine emitted both the geometry carrier and inline max-width, so editor validation compared core's save output against extra markup and marked the paragraph invalid. The carrier already preserves the visual width; removing the unsupported duplicate representation restores save-shape parity.The fixture regressions also prove generated color support classes stay out of
classNameandhas-text-colorappears exactly once in rendered paragraph markup.How to test
cd php-transformer.composer install.composer test.10-nonprofit,13-realistic-small-business, and74-lumen-coffee, with all 230 parity fixtures and the packaging proof passing.git diff --checkfrom the repository root.Backward compatibility
This changes serialized output consumed outside the package:
core/paragraphno longer receives unsupportedstyle.dimensions.maxWidthor matching inlinemax-width. The effective width remains preserved by the existing generated geometry carrier class and CSS. Supported paragraph styles, author classes, deterministic output, and public APIs are unchanged.Verification
composer test: passedgit diff --check: passedComposer validate and test: passedAI assistance