Skip to content

Normalize legacy frameset navigation#607

Closed
chubes4 wants to merge 1 commit into
trunkfrom
fix/606-legacy-frameset
Closed

Normalize legacy frameset navigation#607
chubes4 wants to merge 1 commit into
trunkfrom
fix/606-legacy-frameset

Conversation

@chubes4

@chubes4 chubes4 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Finalized Homeboy agent-task cook run blocks-engine-606-legacy-frameset into review-ready branch fix/606-legacy-frameset.

Proof provenance

  • Proof runner: Homeboy agent-task cook loop
  • Proof ID: agent-task-finalization:blocks-engine-606-legacy-frameset
  • Homeboy run ID: blocks-engine-606-legacy-frameset
  • Manual proof: none recorded by this Homeboy finalization

Publication intent

  • Schema: homeboy/agent-task-publication-intent/v1
  • Action: review_request
  • Target kind: code_review
  • Adapter: github_pull_request
  • Base: trunk
  • Head: fix/606-legacy-frameset

Source refs

Attempt summary

green deterministic gates completed

Gate results

  • php-transformer: passed (targeted)
  • diff-check: passed (targeted)

Verification capability

  • targeted_checks_run: cd php-transformer && composer test, git diff --check
  • targeted_checks_unavailable: none recorded
  • ci_expected: none recorded
  • manual_reviewer_check: Run isolated SSI fixture 30-cursed-pangolin-fanwiki and confirm editor/frontend navigation complete without recursive frame resource amplification.

CI-equivalent coverage

  • CI-equivalent required gate: CI-equivalent required gate was not recorded; targeted proof must not be treated as full CI coverage

Changed files

  • php-transformer/src/HtmlToBlocks/DocumentNormalizationPolicy.php
  • php-transformer/src/HtmlToBlocks/FallbackDiagnostic.php
  • php-transformer/src/HtmlToBlocks/HtmlTransformer.php
  • php-transformer/tests/contract/finding-contract.php
  • php-transformer/tests/fixtures/parity/html-legacy-frameset-noframes-fallback.json

Artifact refs

  • none recorded

Final status

  • Status: review-ready
  • Base: trunk
  • Head: fix/606-legacy-frameset
  • Merge/deploy: not performed

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenCode orchestrated by Homeboy
  • Model: openai/gpt-5.6-sol
  • Used for: Diagnosed recursive legacy frame navigation, implemented generic noframes normalization and typed diagnostics, and added deterministic coverage with Chris.

@chubes4

chubes4 commented Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Closing after live candidate validation. The diagnostic and normalization behaved as implemented, but the intentionally cursed fanwiki fixture remained a deliberate stress timeout and is not a supported target. We are not shipping production scope solely to make this adversarial fixture pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant